webrtc/video/screenshare_loopback.cc - Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/screenshare_loopback.cc

Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int> Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Code review feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/video/screenshare_loopback.cc

diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc

index 91002ef9043484f0b82b8b650e35ee3c617d0d00..4e82a9d495532fa3e1633bda1ce2713d471d38d5 100644

--- a/webrtc/video/screenshare_loopback.cc

+++ b/webrtc/video/screenshare_loopback.cc

@@ -219,7 +219,8 @@ void Loopback() {

Call::Config::BitrateConfig call_bitrate_config;

call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000;

call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000;

- call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;

+ call_bitrate_config.max_bitrate_bps =

+ rtc::Optional<int>(flags::MaxBitrateKbps() * 1000);

VideoQualityTest::Params params{

{flags::Width(), flags::Height(), flags::Fps(),

« no previous file with comments | « webrtc/pc/mediasession_unittest.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »