webrtc/media/base/rtpdataengine_unittest.cc - Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/rtpdataengine_unittest.cc

Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int> Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Code review feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/base/rtpdataengine_unittest.cc

diff --git a/webrtc/media/base/rtpdataengine_unittest.cc b/webrtc/media/base/rtpdataengine_unittest.cc

index b5cfd3255189e6444788247030fe4aefae4bd280..5df242828488f985e36c2872a32d7631802873bf 100644

--- a/webrtc/media/base/rtpdataengine_unittest.cc

+++ b/webrtc/media/base/rtpdataengine_unittest.cc

@@ -378,7 +378,7 @@ TEST_F(RtpDataMediaChannelTest, SendDataRate) {

// With rtp overhead of 32 bytes, each one of our packets is 36

// bytes, or 288 bits. So, a limit of 872bps will allow 3 packets,

// but not four.

- parameters.max_bandwidth_bps = 872;

+ parameters.max_bitrate_bps = rtc::Optional<int>(872);

ASSERT_TRUE(dmc->SetSendParameters(parameters));

EXPECT_TRUE(dmc->SendData(params, payload, &result));

« no previous file with comments | « webrtc/media/base/rtpdataengine.cc ('k') | webrtc/media/base/videoengine_unittest.h » ('j') | no next file with comments »