webrtc/api/rtpparameters.h - Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/rtpparameters.h

Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int> Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Code review feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/rtpparameters.h

diff --git a/webrtc/api/rtpparameters.h b/webrtc/api/rtpparameters.h

index 2c29d9843d9ee597c81e313e2476f05344065b40..3a923436e0db14caf7ce0303339d31f9d88fe78b 100644

--- a/webrtc/api/rtpparameters.h

+++ b/webrtc/api/rtpparameters.h

@@ -12,6 +12,7 @@

#define WEBRTC_API_RTPPARAMETERS_H_

#include <vector>

+#include "webrtc/base/optional.h"

namespace webrtc {

@@ -19,7 +20,7 @@ namespace webrtc {

// See http://w3c.github.io/webrtc-pc/#rtcrtpsender-interface for details.

struct RtpEncodingParameters {

bool active = true;

- int max_bitrate_bps = -1;

+ rtc::Optional<int> max_bitrate_bps;

};

struct RtpParameters {

« no previous file with comments | « webrtc/api/mediacontroller.cc ('k') | webrtc/api/webrtcsdp.cc » ('j') | no next file with comments »