Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/video/screenshare_loopback.cc

Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int> Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: More code review feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/media/engine/webrtcvoiceengine.cc ('K') | « webrtc/pc/mediasession_unittest.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/screenshare_loopback.cc
diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc
index 91002ef9043484f0b82b8b650e35ee3c617d0d00..4e82a9d495532fa3e1633bda1ce2713d471d38d5 100644
--- a/webrtc/video/screenshare_loopback.cc
+++ b/webrtc/video/screenshare_loopback.cc
@@ -219,7 +219,8 @@ void Loopback() {
Call::Config::BitrateConfig call_bitrate_config;
call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000;
call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000;
- call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
+ call_bitrate_config.max_bitrate_bps =
+ rtc::Optional<int>(flags::MaxBitrateKbps() * 1000);
VideoQualityTest::Params params{
{flags::Width(), flags::Height(), flags::Fps(),
« webrtc/media/engine/webrtcvoiceengine.cc ('K') | « webrtc/pc/mediasession_unittest.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698