webrtc/media/base/rtpdataengine.h - Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/rtpdataengine.h

Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int> Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: More code review feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/base/rtpdataengine.h

diff --git a/webrtc/media/base/rtpdataengine.h b/webrtc/media/base/rtpdataengine.h

index 62eebf63c1247291b96356dfa4dbb32a98ec4e32..bcaa6d1655f0eb3035643d558fc048e1a7ea0d12 100644

--- a/webrtc/media/base/rtpdataengine.h

+++ b/webrtc/media/base/rtpdataengine.h

@@ -105,7 +105,7 @@ class RtpDataMediaChannel : public DataMediaChannel {

private:

void Construct(rtc::Timing* timing);

- bool SetMaxSendBandwidth(int bps);

+ bool SetMaxSendBandwidth(rtc::Optional<int> bps);

bool SetSendCodecs(const std::vector<DataCodec>& codecs);

bool SetRecvCodecs(const std::vector<DataCodec>& codecs);

« webrtc/call/call.cc ('K') | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/base/rtpdataengine.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')