Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: webrtc/api/webrtcsdp_unittest.cc

Issue 1813763005: Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int> Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: More code review feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/webrtcsdp_unittest.cc
diff --git a/webrtc/api/webrtcsdp_unittest.cc b/webrtc/api/webrtcsdp_unittest.cc
index 95597016420f54d14acde1e60c8f7a5004f75a14..a296f9efc79bde6e4638cde325a7727837a9d912 100644
--- a/webrtc/api/webrtcsdp_unittest.cc
+++ b/webrtc/api/webrtcsdp_unittest.cc
@@ -1895,10 +1895,10 @@ TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithBundle) {
TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithBandwidth) {
VideoContentDescription* vcd = static_cast<VideoContentDescription*>(
GetFirstVideoContent(&desc_)->description);
- vcd->set_bandwidth(100 * 1000);
+ vcd->set_bandwidth(rtc::Optional<int>(100 * 1000));
AudioContentDescription* acd = static_cast<AudioContentDescription*>(
GetFirstAudioContent(&desc_)->description);
- acd->set_bandwidth(50 * 1000);
+ acd->set_bandwidth(rtc::Optional<int>(50 * 1000));
ASSERT_TRUE(jdesc_.Initialize(desc_.Copy(),
jdesc_.session_id(),
jdesc_.session_version()));
@@ -2017,7 +2017,7 @@ TEST_F(WebRtcSdpTest, SerializeWithSctpDataChannelAndNewPort) {
TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithDataChannelAndBandwidth) {
AddRtpDataChannel();
- data_desc_->set_bandwidth(100*1000);
+ data_desc_->set_bandwidth(rtc::Optional<int>(100 * 1000));
JsepSessionDescription jsep_desc(kDummyString);
ASSERT_TRUE(jsep_desc.Initialize(desc_.Copy(), kSessionId, kSessionVersion));
@@ -2220,10 +2220,10 @@ TEST_F(WebRtcSdpTest, DeserializeSessionDescriptionWithBandwidth) {
SdpDeserialize(sdp_with_bandwidth, &jdesc_with_bandwidth));
VideoContentDescription* vcd = static_cast<VideoContentDescription*>(
GetFirstVideoContent(&desc_)->description);
- vcd->set_bandwidth(100 * 1000);
+ vcd->set_bandwidth(rtc::Optional<int>(100 * 1000));
AudioContentDescription* acd = static_cast<AudioContentDescription*>(
GetFirstAudioContent(&desc_)->description);
- acd->set_bandwidth(50 * 1000);
+ acd->set_bandwidth(rtc::Optional<int>(50 * 1000));
ASSERT_TRUE(jdesc_.Initialize(desc_.Copy(),
jdesc_.session_id(),
jdesc_.session_version()));
@@ -2601,7 +2601,7 @@ TEST_F(WebRtcSdpTest, DeserializeSdpWithSctpDataChannelsAndBandwidth) {
JsepSessionDescription jdesc(kDummyString);
DataContentDescription* dcd = static_cast<DataContentDescription*>(
GetFirstDataContent(&desc_)->description);
- dcd->set_bandwidth(100 * 1000);
+ dcd->set_bandwidth(rtc::Optional<int>(100 * 1000));
ASSERT_TRUE(jdesc.Initialize(desc_.Copy(), kSessionId, kSessionVersion));
std::string sdp_with_bandwidth = kSdpString;

Powered by Google App Engine
This is Rietveld 408576698