Updated structures and functions for setting the max bitrate limit to take rtc::Optional<int>

webrtc/base/optional_ios.h

+/*
+ *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_BASE_OPTIONAL_IOS_H_
+#define WEBRTC_BASE_OPTIONAL_IOS_H_
+
+#include <ostream>
+#include "webrtc/base/optional.h"
+
+namespace rtc {
+
+// Contains function definitions to allow writing rtc::Optional<T> to ostreams.
+// Allows for simpler logging of rtc::Optional<T> values.
+
+template <typename T>
+std::ostream& operator<<(std::ostream& stream, rtc::Optional<T> value) {
+  if (value) {
+    stream << *value;
+  } else {
+    stream << "<not set>";
+  }
+  return stream;
+}

[pthatcher1, 2016/03/17 21:51:28]

Can we put this in optional.h?  Is the dependency on ostream that bad?

Also, a name like "_ios" makes it sound like iOS.

[skvlad, 2016/03/18 00:49:17]

Ok - moved it to optional.h. The ostream dependency is nothing to worry about.
My original motivation for keeping it separate was that this operator is only
used for logging and is not really related to core functionality - it's not even
a member of the Optional class.

+
+}  // namespace rtc
+
+#endif  // WEBRTC_BASE_OPTIONAL_IOS_H_