webrtc/modules/video_render/windows/video_render_windows_impl.cc - Issue 1813173002: Deletes the class VideoRendererCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_render/windows/video_render_windows_impl.cc

Issue 1813173002: Deletes the class VideoRendererCallback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Break long lines. Add explicit keyword on IncomingVideoStream constructor. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_render/windows/video_render_windows_impl.cc

diff --git a/webrtc/modules/video_render/windows/video_render_windows_impl.cc b/webrtc/modules/video_render/windows/video_render_windows_impl.cc

index 042d7fdfa335f54a6f0bac3d931573479b1272cb..5f0a39becc7d5d023ce1ee506eb86bd2cdf5e4ea 100644

--- a/webrtc/modules/video_render/windows/video_render_windows_impl.cc

+++ b/webrtc/modules/video_render/windows/video_render_windows_impl.cc

@@ -84,7 +84,7 @@ int32_t VideoRenderWindowsImpl::ChangeWindow(void* window)

}

-VideoRenderCallback*

+rtc::VideoSinkInterface<VideoFrame>*

VideoRenderWindowsImpl::AddIncomingRenderStream(const uint32_t streamId,

const uint32_t zOrder,

const float left,

@@ -93,7 +93,7 @@ VideoRenderWindowsImpl::AddIncomingRenderStream(const uint32_t streamId,

const float bottom)

{

CriticalSectionScoped cs(&_renderWindowsCritsect);

- VideoRenderCallback* renderCallback = NULL;

+ rtc::VideoSinkInterface<VideoFrame>* renderCallback = NULL;

if (!_ptrRendererWin)

{