Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: webrtc/modules/video_render/video_render_internal_impl.cc

Issue 1813173002: Deletes the class VideoRendererCallback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Break long lines. Add explicit keyword on IncomingVideoStream constructor. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_render/video_render_internal_impl.cc
diff --git a/webrtc/modules/video_render/video_render_internal_impl.cc b/webrtc/modules/video_render/video_render_internal_impl.cc
index 2090fce5f86869a5e84bc258448074c0cb3e14d5..ad0c6c58ac82e08bd0c294c65e7ac1de76791e7d 100644
--- a/webrtc/modules/video_render/video_render_internal_impl.cc
+++ b/webrtc/modules/video_render/video_render_internal_impl.cc
@@ -380,7 +380,7 @@ uint32_t ModuleVideoRenderImpl::GetIncomingFrameRate(const uint32_t streamId) {
return it->second->IncomingRate();
}
-VideoRenderCallback*
+rtc::VideoSinkInterface<VideoFrame>*
ModuleVideoRenderImpl::AddIncomingRenderStream(const uint32_t streamId,
const uint32_t zOrder,
const float left,
@@ -404,7 +404,7 @@ ModuleVideoRenderImpl::AddIncomingRenderStream(const uint32_t streamId,
return NULL;
}
- VideoRenderCallback* ptrRenderCallback =
+ rtc::VideoSinkInterface<VideoFrame>* ptrRenderCallback =
_ptrRenderer->AddIncomingRenderStream(streamId, zOrder, left, top,
right, bottom);
if (ptrRenderCallback == NULL)
@@ -417,9 +417,10 @@ ModuleVideoRenderImpl::AddIncomingRenderStream(const uint32_t streamId,
// Create platform independant code
IncomingVideoStream* ptrIncomingStream =
- new IncomingVideoStream(streamId, false);
+ new IncomingVideoStream(false);
ptrIncomingStream->SetRenderCallback(ptrRenderCallback);
- VideoRenderCallback* moduleCallback = ptrIncomingStream->ModuleCallback();
+ rtc::VideoSinkInterface<VideoFrame>* moduleCallback =
+ ptrIncomingStream->ModuleCallback();
// Store the stream
_streamRenderMap[streamId] = ptrIncomingStream;
@@ -458,7 +459,7 @@ int32_t ModuleVideoRenderImpl::DeleteIncomingRenderStream(
int32_t ModuleVideoRenderImpl::AddExternalRenderCallback(
const uint32_t streamId,
- VideoRenderCallback* renderObject) {
+ rtc::VideoSinkInterface<VideoFrame>* renderObject) {
CriticalSectionScoped cs(&_moduleCrit);
IncomingVideoStreamMap::iterator item = _streamRenderMap.find(streamId);
@@ -516,7 +517,7 @@ bool ModuleVideoRenderImpl::HasIncomingRenderStream(
int32_t ModuleVideoRenderImpl::RegisterRawFrameCallback(
const uint32_t streamId,
- VideoRenderCallback* callbackObj) {
+ rtc::VideoSinkInterface<VideoFrame>* callbackObj) {
return -1;
}

Powered by Google App Engine
This is Rietveld 408576698