Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1813053007: Update CPU Monitor to report CPU frequency and battery level. (Closed)

Created:
4 years, 9 months ago by AlexG
Modified:
4 years, 9 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update CPU Monitor to report CPU frequency and battery level. R=wzh@webrtc.org Committed: https://crrev.com/e56b99ed020a18a792c8727650fd77c458d45b8b Cr-Commit-Position: refs/heads/master@{#12081}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -79 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 5 chunks +11 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java View 1 10 chunks +266 lines, -71 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/HudFragment.java View 3 chunks +8 lines, -6 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/util/LooperExecutor.java View 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
AlexG
PTAL
4 years, 9 months ago (2016-03-19 01:18:03 UTC) #2
wzh
lgtm https://codereview.webrtc.org/1813053007/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java File webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java (right): https://codereview.webrtc.org/1813053007/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java#newcode78 webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java:78: private static final String DUMP_FILE = "log.txt"; nit: ...
4 years, 9 months ago (2016-03-21 16:47:06 UTC) #3
AlexG
https://codereview.webrtc.org/1813053007/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java File webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java (right): https://codereview.webrtc.org/1813053007/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java#newcode78 webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java:78: private static final String DUMP_FILE = "log.txt"; On 2016/03/21 ...
4 years, 9 months ago (2016-03-21 20:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813053007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813053007/20001
4 years, 9 months ago (2016-03-21 20:25:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11941)
4 years, 9 months ago (2016-03-21 21:17:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813053007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813053007/20001
4 years, 9 months ago (2016-03-21 21:19:01 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11944)
4 years, 9 months ago (2016-03-21 22:12:27 UTC) #13
AlexG
Committed patchset #2 (id:20001) manually as e56b99ed020a18a792c8727650fd77c458d45b8b (presubmit successful).
4 years, 9 months ago (2016-03-21 23:24:54 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e56b99ed020a18a792c8727650fd77c458d45b8b Cr-Commit-Position: refs/heads/master@{#12081}
4 years, 9 months ago (2016-03-21 23:24:56 UTC) #17
kjellander_webrtc
4 years, 9 months ago (2016-03-22 10:25:27 UTC) #18
Message was sent while issue was closed.
On 2016/03/21 23:24:56, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/e56b99ed020a18a792c8727650fd77c458d45b8b
> Cr-Commit-Position: refs/heads/master@{#12081}

Android failures caused by https://codereview.chromium.org/1818083003/ which has
now been reverted. Feel free to ignore those.

Powered by Google App Engine
This is Rietveld 408576698