Move swap_queue.h to base/

Move swap_queue.h to base/

This will let us use the SwapQueue as a message queue for the event log's output thread. See https://codereview.webrtc.org/1687703002/

Committed: https://crrev.com/85fa7d5311f218fe84fc40cfda79471d0108f1ec
Cr-Commit-Position: refs/heads/master@{#12113}

[terelius, 2016-03-18 13:59:16]

terelius@webrtc.org changed reviewers:
+ henrikg@webrtc.org, solenberg@webrtc.org

[terelius, 2016-03-18 13:59:16]

terelius@webrtc.org changed required reviewers:
+ henrikg@webrtc.org

[terelius, 2016-03-18 13:59:17]

Please take a look.

[Henrik Grunell WebRTC, 2016-03-21 09:51:57]

On 2016/03/18 13:59:17, terelius wrote:
> Please take a look.

Please add why this change is done in the description.

Also, either add a bug reference (preferably) or remove the BUG= line. Is this
maybe part of some larger refactoring effort, that has a bug?

Lastly, which files should I review (since multiple reviewers)?

[terelius, 2016-03-21 10:07:48]

Description was changed from

==========
Move swap_queue.h to base/

BUG=
==========

to

==========
Move swap_queue.h to base/

This will let us use the SwapQueue as a message queue for the event log's output
thread. See https://codereview.webrtc.org/1687703002/
==========

[the sun, 2016-03-21 11:27:28]

lgtm

[the sun, 2016-03-21 11:29:44]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, peah@webrtc.org

[the sun, 2016-03-21 11:29:44]

+ kwiberg@ for common_audio
+ peah@ for modules/audio_processing

[kwiberg-webrtc, 2016-03-21 11:41:47]

On 2016/03/21 11:29:44, the sun wrote:
> + kwiberg@ for common_audio

lgtm for common_audio

[peah-webrtc, 2016-03-21 11:42:43]

On 2016/03/21 11:41:47, kwiberg-webrtc wrote:
> On 2016/03/21 11:29:44, the sun wrote:
> > + kwiberg@ for common_audio
> 
> lgtm for common_audio

lgtm for audio processing

[terelius, 2016-03-21 11:59:19]

On 2016/03/21 09:51:57, Henrik Grunell (webrtc) wrote:
> On 2016/03/18 13:59:17, terelius wrote:
> > Please take a look.
> 
> Please add why this change is done in the description.
> 
> Also, either add a bug reference (preferably) or remove the BUG= line. Is this
> maybe part of some larger refactoring effort, that has a bug?
> 
> Lastly, which files should I review (since multiple reviewers)?

There is a general bug for the event log, but I don't have any specific bug for
this change. Would you like me to create one?

Henrik, please review base/. (I picked you as base/ OWNER because you have
reviewed the SwapQueue, if I recall correctly.)

[Henrik Grunell WebRTC, 2016-03-21 12:24:21]

On 2016/03/21 11:59:19, terelius wrote:
> On 2016/03/21 09:51:57, Henrik Grunell (webrtc) wrote:
> > On 2016/03/18 13:59:17, terelius wrote:
> > > Please take a look.
> > 
> > Please add why this change is done in the description.
> > 
> > Also, either add a bug reference (preferably) or remove the BUG= line. Is
this
> > maybe part of some larger refactoring effort, that has a bug?
> > 
> > Lastly, which files should I review (since multiple reviewers)?
> 
> There is a general bug for the event log, but I don't have any specific bug
for
> this change. Would you like me to create one?

OK. I'll leave it up to you to determine what makes more sense, to leave bug
number out or use the event log bug.

> Henrik, please review base/. (I picked you as base/ OWNER because you have
> reviewed the SwapQueue, if I recall correctly.)

I don't think I did. :) But I've reviewed it, it's just a move.

[Henrik Grunell WebRTC, 2016-03-21 12:24:29]

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/base.gyp#newc...
webrtc/base/base.gyp:129: 'swap_queue.h',
Does it have to be in the "approved" target?

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/swap_queue.h
File webrtc/base/swap_queue.h (right):

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/swap_queue.h#...
webrtc/base/swap_queue.h:25: // (Internal; please don't use outside this file.)
Is this something we want to expose as part of approved code to use outside of
WebRTC?

[terelius, 2016-03-23 10:21:02]

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/base.gyp#newc...
webrtc/base/base.gyp:129: 'swap_queue.h',
On 2016/03/21 12:24:29, Henrik Grunell (webrtc) wrote:
> Does it have to be in the "approved" target?

Yes. The SwapQueue is used by e.g. the audio_processing module, which depends on
rtc_base_approved but not on rtc_base.

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/swap_queue.h
File webrtc/base/swap_queue.h (right):

https://codereview.webrtc.org/1812823007/diff/20001/webrtc/base/swap_queue.h#...
webrtc/base/swap_queue.h:25: // (Internal; please don't use outside this file.)
On 2016/03/21 12:24:29, Henrik Grunell (webrtc) wrote:
> Is this something we want to expose as part of approved code to use outside of
> WebRTC?

I think "approved" means primarily "approved for use outside of libjingle".
Although it does expose the internal namespace to code outside of WebRTC, we do
the same thing in e.g. base/buffer.h

[Henrik Grunell WebRTC, 2016-03-23 10:34:59]

lgtm

[terelius, 2016-03-23 11:01:26]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-03-23 11:01:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812823007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812823007/20001

[commit-bot: I haz the power, 2016-03-23 13:02:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 13:02:07]

Try jobs failed on following builders:
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[terelius, 2016-03-24 08:50:10]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-03-24 08:50:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812823007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812823007/20001

[commit-bot: I haz the power, 2016-03-24 08:51:56]

Description was changed from

==========
Move swap_queue.h to base/

This will let us use the SwapQueue as a message queue for the event log's output
thread. See https://codereview.webrtc.org/1687703002/
==========

to

==========
Move swap_queue.h to base/

This will let us use the SwapQueue as a message queue for the event log's output
thread. See https://codereview.webrtc.org/1687703002/
==========

[commit-bot: I haz the power, 2016-03-24 08:51:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 08:52:04]

Description was changed from

==========
Move swap_queue.h to base/

This will let us use the SwapQueue as a message queue for the event log's output
thread. See https://codereview.webrtc.org/1687703002/
==========

to

==========
Move swap_queue.h to base/

This will let us use the SwapQueue as a message queue for the event log's output
thread. See https://codereview.webrtc.org/1687703002/

Committed: https://crrev.com/85fa7d5311f218fe84fc40cfda79471d0108f1ec
Cr-Commit-Position: refs/heads/master@{#12113}
==========

[commit-bot: I haz the power, 2016-03-24 08:52:06]

Patchset 2 (id:??) landed as
https://crrev.com/85fa7d5311f218fe84fc40cfda79471d0108f1ec
Cr-Commit-Position: refs/heads/master@{#12113}