Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1812593002: Enable Continual gathering in apprtcdemo. (Closed)

Created:
4 years, 9 months ago by honghaiz3
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable Continual gathering in apprtcdemo. This will help test or debug the continual gathering policy. BUG= Committed: https://crrev.com/8811b35960ab9cf25ff8a862ecd9c24c4f2bf5fd Cr-Commit-Position: refs/heads/master@{#12038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
honghaiz3
4 years, 9 months ago (2016-03-16 18:06:12 UTC) #2
pthatcher1
lgtm
4 years, 9 months ago (2016-03-16 21:25:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812593002/1
4 years, 9 months ago (2016-03-16 21:36:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4188)
4 years, 9 months ago (2016-03-16 21:44:03 UTC) #7
honghaiz3
4 years, 9 months ago (2016-03-17 02:52:13 UTC) #9
AlexG
lgtm
4 years, 9 months ago (2016-03-17 16:24:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812593002/1
4 years, 9 months ago (2016-03-17 16:42:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 16:43:46 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8811b35960ab9cf25ff8a862ecd9c24c4f2bf5fd Cr-Commit-Position: refs/heads/master@{#12038}
4 years, 9 months ago (2016-03-17 16:43:57 UTC) #15
tkchin_webrtc
4 years, 9 months ago (2016-03-17 17:50:55 UTC) #17
Message was sent while issue was closed.
For parity, can we enable this on the iOS AppRTCDemo as well? It's easy to miss
features that should be available on both platforms (e.g. I missed when send
side BWE was added).

Powered by Google App Engine
This is Rietveld 408576698