Chromium Code Reviews

Issue 1812453002: Revert of Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@voe_dtmf_7
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code. (patchset #2 id:20001 of https://codereview.webrtc.org/1802993002/ ) Reason for revert: Revert because it breaks downstream code. Original issue's description: > Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code. > > BUG=webrtc:4690 > > Committed: https://crrev.com/69a81999ace08e40e2b2ec526b0e111aa11b9538 > Cr-Commit-Position: refs/heads/master@{#12015} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Committed: https://crrev.com/b69395b374746a101cf11203303a747e2c88df32 Cr-Commit-Position: refs/heads/master@{#12016}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+66 lines, -16 lines)
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 1 chunk +1 line, -0 lines 0 comments
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 2 chunks +20 lines, -0 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 2 chunks +4 lines, -1 line 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 2 chunks +9 lines, -6 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +1 line, -0 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 2 chunks +11 lines, -3 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 1 chunk +3 lines, -1 line 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_utility.h View 1 chunk +1 line, -0 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 4 chunks +7 lines, -2 lines 0 comments
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 2 chunks +2 lines, -2 lines 0 comments
M webrtc/voice_engine/channel.cc View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 6 (1 generated)
the sun
Created Revert of Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code.
4 years, 9 months ago (2016-03-16 14:05:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812453002/1
4 years, 9 months ago (2016-03-16 14:05:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 14:05:21 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b69395b374746a101cf11203303a747e2c88df32 Cr-Commit-Position: refs/heads/master@{#12016}
4 years, 9 months ago (2016-03-16 14:05:27 UTC) #5
hlundin-webrtc
4 years, 9 months ago (2016-03-16 15:51:12 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine