Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1812433002:
Added a bitexactness test for the gain controller in the audio processing module. (Closed)
|
Created:
4 years, 9 months ago by peah-webrtc Modified:
4 years, 9 months ago Reviewers:
hlundin-webrtc CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@AecmBitExactness_CL Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded a bitexactness test for the gain controller in the audio processing module.
BUG=webrtc:5339
Committed: https://crrev.com/a49dc36976da44f3d6d75aed2dcab93fe14fc3a0
Cr-Commit-Position: refs/heads/master@{#12124}
Patch Set 1 : #
Total comments: 8
Patch Set 2 : Changes in response to reviewer comments #Patch Set 3 : Rebase #
Messages
Total messages: 36 (19 generated)
Patchset #1 (id:1) has been deleted
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org
LGTM with comments. https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/gain_control_unittest.cc (right): https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:52: static_cast<GainControl*>(gain_controller)->Enable(true); GainControl* gc = static_cast<GainControl*>(gain_controller); gc->Enable(true); ... https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:84: int samples_per_channel = rtc::CheckedDivExact(sample_rate_hz, 100); const https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:122: const float kTolerance = 1.0f / 32768.0f; Move tolerance down. https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:123: EXPECT_EQ(achieved_stream_analog_level_reference, EXPECT_EQ(achieved_stream_analog_level_reference, gain_controller.stream_analog_level());
https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/gain_control_unittest.cc (right): https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:52: static_cast<GainControl*>(gain_controller)->Enable(true); On 2016/03/18 08:32:31, hlundin-webrtc wrote: > GainControl* gc = static_cast<GainControl*>(gain_controller); > gc->Enable(true); > ... Done. https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:84: int samples_per_channel = rtc::CheckedDivExact(sample_rate_hz, 100); On 2016/03/18 08:32:31, hlundin-webrtc wrote: > const Done. https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:122: const float kTolerance = 1.0f / 32768.0f; On 2016/03/18 08:32:31, hlundin-webrtc wrote: > Move tolerance down. Done. https://codereview.webrtc.org/1812433002/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/gain_control_unittest.cc:123: EXPECT_EQ(achieved_stream_analog_level_reference, On 2016/03/18 08:32:30, hlundin-webrtc wrote: > EXPECT_EQ(achieved_stream_analog_level_reference, > gain_controller.stream_analog_level()); Done.
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812433002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_ubsan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/681)
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1812433002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812433002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/10800)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812433002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/10845)
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812433002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812433002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/10880)
Patchset #6 (id:120001) has been deleted
Patchset #5 (id:100001) has been deleted
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812433002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1812433002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812433002/60001
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Added a bitexactness test for the gain controller in the audio processing module. BUG=webrtc:5339 ========== to ========== Added a bitexactness test for the gain controller in the audio processing module. BUG=webrtc:5339 Committed: https://crrev.com/a49dc36976da44f3d6d75aed2dcab93fe14fc3a0 Cr-Commit-Position: refs/heads/master@{#12124} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a49dc36976da44f3d6d75aed2dcab93fe14fc3a0 Cr-Commit-Position: refs/heads/master@{#12124}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.webrtc.org/1829323002/ by peah@webrtc.org. The reason for reverting is: This CL are breaking some of the Android buildbots in Chromium. The CL will need be be revised to exclude the Android platform.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
