Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1811453002: WebRtcIsacfix_PitchFilter: Don't read uninitialized array entries (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
turaj
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcIsacfix_PitchFilter: Don't read uninitialized array entries WebRtcIsacfix_PitchFilterCore requires indW32 >= PITCH_FRACORDER - 2; otherwise, it will read from entries of ubufQQ that haven't been written yet. (The problem of indW32 being too small has only been seen in fuzzer tests, not in real life.) BUG=chromium:581901 Committed: https://crrev.com/15622c0aafd65df790af1def89dc6d4454e3b35a Cr-Commit-Position: refs/heads/master@{#12047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-16 19:20:18 UTC) #4
turaj
lgtm
4 years, 9 months ago (2016-03-17 17:18:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811453002/1
4 years, 9 months ago (2016-03-17 18:07:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-17 21:22:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811453002/1
4 years, 9 months ago (2016-03-18 05:12:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 05:17:19 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 05:17:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15622c0aafd65df790af1def89dc6d4454e3b35a
Cr-Commit-Position: refs/heads/master@{#12047}

Powered by Google App Engine
This is Rietveld 408576698