Added a bitexactness test for the level estimator in the audio processing module

webrtc/modules/audio_processing/test/bitexactness_tools.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <math.h>
 #include <string>
 
 #include "webrtc/base/array_view.h"
 #include "webrtc/modules/audio_processing/test/bitexactness_tools.h"
 
 namespace webrtc {
 namespace test {
 
+::testing::AssertionResult AssertIntegersNotEqual(const char* m_expr,

[hlundin-webrtc, 2016/03/16 12:57:05]

Consider using EXPECT_NEAR instead of this custom predicate.

[peah-webrtc, 2016/03/17 14:18:06]

Done.

+                                                  const char* n_expr,
+                                                  const int& output,
+                                                  const int& reference) {
+  // Compare the output in the reference in a soft manner.
+  const int kThreshold = 1.0;
+  bool equal = (abs(output - reference) <= kThreshold);
+
+  // If the values are deemed not to be similar, return a report of the
+  // difference.
+  if (!equal) {
+    return ::testing::AssertionFailure()
+           << "Actual: " << std::to_string(output) << std::endl
+           << "Expected: " << std::to_string(reference) << std::endl;
+  }
+  return ::testing::AssertionSuccess();
+}
+
 ::testing::AssertionResult AssertFloatsNotEqual(const char* m_expr,
                                                 const char* n_expr,
                                                 const float& output,
                                                 const float& reference) {
   // Compare the output in the reference in a soft manner.
-  float threshold = 1.0f / 32768.0f;
-  bool equal = (fabs(output - reference) <= threshold);
+  const float kThreshold = 1.0f / 32768.0f;
+  bool equal = (fabs(output - reference) <= kThreshold);
 
   // If the values are deemed not to be similar, return a report of the
   // difference.
   if (!equal) {
-    // Lambda function that produces a formatted string with the values.
     return ::testing::AssertionFailure()
            << "Actual: " << std::to_string(output) + "f" << std::endl
            << "Expected: " << std::to_string(reference) + "f" << std::endl;
   }
   return ::testing::AssertionSuccess();
 }
 
 ::testing::AssertionResult AssertVectorsNotEqual(
     const char* m_expr,
     const char* n_expr,
     const rtc::ArrayView<const float>& output,
     const rtc::ArrayView<const float>& reference) {
   // Compare the output in the reference in a soft manner.
-  float threshold = 1.0f / 32768.0f;
+  float kThreshold = 1.0f / 32768.0f;
   bool equal = true;
   for (size_t k = 0; k < reference.size(); ++k) {
-    if (fabs(output[k] - reference[k]) > threshold) {
+    if (fabs(output[k] - reference[k]) > kThreshold) {
       equal = false;
       break;
     }
   }
 
   // If the vectors are deemed not to be similar, return a report of the
   // difference.
   if (!equal) {
     // Lambda function that produces a formatted string with the data in the
     // vector.
@@ skipping 12 matching lines @@
            << std::endl
            << "Expected: "
            << print_vector_in_c_format(reference, reference.size())
            << std::endl;
   }
   return ::testing::AssertionSuccess();
 }
 
 }  // namespace test
 }  // namespace webrtc