Fix broken CVO header extension

Fix broken CVO header extension

Adds end to end unit tests for CVO.

BUG=webrtc:5621
Committed: https://crrev.com/caafdba0e4acd527549906d9df113affbdc0cb80
Cr-Commit-Position: refs/heads/master@{#12063}

[pthatcher1, 2016-03-18 17:04:47]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-03-18 17:04:48]

I'm not sure why you hadn't mailed this out for review (or the tests not passing
yet)?  But the tests look good.

The only thing I would want is for a test in webrtcvideoengine2_unittest.cc that
could catch this bug as well (the early return one).

[perkj_webrtc, 2016-03-18 17:10:18]

On 2016/03/18 17:04:48, pthatcher1 wrote:
> I'm not sure why you hadn't mailed this out for review (or the tests not
passing
> yet)?  But the tests look good.
> 
> The only thing I would want is for a test in webrtcvideoengine2_unittest.cc
that
> could catch this bug as well (the early return one).

I did not send it because the unit test does not pass and I need to leave...
Sorry-

[perkj_webrtc, 2016-03-18 17:11:02]

On 2016/03/18 17:10:18, perkj_webrtc wrote:
> On 2016/03/18 17:04:48, pthatcher1 wrote:
> > I'm not sure why you hadn't mailed this out for review (or the tests not
> passing
> > yet)?  But the tests look good.
> > 
> > The only thing I would want is for a test in webrtcvideoengine2_unittest.cc
> that
> > could catch this bug as well (the early return one).
> 
> I did not send it because the unit test does not pass and I need to leave...
> Sorry-

But the fix itself works...tested on Android ApprtcDemo.

[perkj_webrtc, 2016-03-18 20:30:38]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 20:30:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811373002/40001

[perkj_webrtc, 2016-03-18 20:38:56]

No idea why the tests did not pass on the machine at work. I suspect my build
got corrupted by switching between linux and Android...

Anyway I added more tests and fixed a recreation issue in the first patch.
Please take a look.  (The trybots are currently running in the patch set 3.)

[perkj_webrtc, 2016-03-18 20:40:09]

Description was changed from

==========
Fix broken CVO header extension

BUG=
==========

to

==========
Fix broken CVO header extension

Adds end to end unit tests for CVO.

BUG=webrtc:5621
==========

[pthatcher1, 2016-03-18 23:26:30]

lgtm

[perkj_webrtc, 2016-03-20 13:34:52]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-03-20 13:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811373002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811373002/60001

[commit-bot: I haz the power, 2016-03-20 14:34:36]

Description was changed from

==========
Fix broken CVO header extension

Adds end to end unit tests for CVO.

BUG=webrtc:5621
==========

to

==========
Fix broken CVO header extension

Adds end to end unit tests for CVO.

BUG=webrtc:5621
==========

[commit-bot: I haz the power, 2016-03-20 14:34:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-20 14:34:43]

Description was changed from

==========
Fix broken CVO header extension

Adds end to end unit tests for CVO.

BUG=webrtc:5621
==========

to

==========
Fix broken CVO header extension

Adds end to end unit tests for CVO.

BUG=webrtc:5621

Committed: https://crrev.com/caafdba0e4acd527549906d9df113affbdc0cb80
Cr-Commit-Position: refs/heads/master@{#12063}
==========

[commit-bot: I haz the power, 2016-03-20 14:34:44]

Patchset 4 (id:??) landed as
https://crrev.com/caafdba0e4acd527549906d9df113affbdc0cb80
Cr-Commit-Position: refs/heads/master@{#12063}