Add support for configuring the number of spatial/temporal layers for VP9 through a field trial.

Add support for configuring the number of spatial/temporal layers for VP9 through a field trial.

BUG=chromium:595695
Committed: https://crrev.com/c5dabdd3fbc6fdebb3e9bd9b1d0d178fe7beface
Cr-Commit-Position: refs/heads/master@{#12073}

[åsapersson, 2016-03-17 14:07:48]

Description was changed from

==========
Add support for configuring the number of spatial/temporal layers for VP9
through a field trial.

BUG=chromium:595695
==========

to

==========
Add support for configuring the number of spatial/temporal layers for VP9
through a field trial.

BUG=chromium:595695
==========

[åsapersson, 2016-03-17 14:07:49]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org, pbos@webrtc.org, stefan@webrtc.org

[pbos-webrtc, 2016-03-17 14:34:38]

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/fakew...
File webrtc/media/engine/fakewebrtccall.cc (right):

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/fakew...
webrtc/media/engine/fakewebrtccall.cc:172: if (!config.streams.empty()) {
Should this be added to vp8 for symmetry as well?

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.cc:485:
encoder_settings_.vp9.numberOfSpatialLayers = GetDefaultVp9SpatialLayers();
I don't think this should apply to screenshare, should it? Otherwise these
DCHECKs should probably be removed as well:

https://chromium.googlesource.com/external/webrtc/+/b4c82474be64b815141284e37...

[åsapersson, 2016-03-17 16:57:34]

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/fakew...
File webrtc/media/engine/fakewebrtccall.cc (right):

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/fakew...
webrtc/media/engine/fakewebrtccall.cc:172: if (!config.streams.empty()) {
On 2016/03/17 14:34:38, pbos-webrtc wrote:
> Should this be added to vp8 for symmetry as well?

Done.

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1810973002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.cc:485:
encoder_settings_.vp9.numberOfSpatialLayers = GetDefaultVp9SpatialLayers();
On 2016/03/17 14:34:38, pbos-webrtc wrote:
> I don't think this should apply to screenshare, should it? Otherwise these
> DCHECKs should probably be removed as well:
> 
>
https://chromium.googlesource.com/external/webrtc/+/b4c82474be64b815141284e37...

Ok, changed so it is not set for screenshare for now. Also, set spatial layers
to 2 if screenshare and added a comment/todo.

[pbos-webrtc, 2016-03-20 20:54:00]

lgtm

[åsapersson, 2016-03-21 11:14:27]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-03-21 11:14:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1810973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1810973002/40001

[commit-bot: I haz the power, 2016-03-21 11:15:54]

Description was changed from

==========
Add support for configuring the number of spatial/temporal layers for VP9
through a field trial.

BUG=chromium:595695
==========

to

==========
Add support for configuring the number of spatial/temporal layers for VP9
through a field trial.

BUG=chromium:595695
==========

[commit-bot: I haz the power, 2016-03-21 11:15:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-21 11:16:00]

Description was changed from

==========
Add support for configuring the number of spatial/temporal layers for VP9
through a field trial.

BUG=chromium:595695
==========

to

==========
Add support for configuring the number of spatial/temporal layers for VP9
through a field trial.

BUG=chromium:595695

Committed: https://crrev.com/c5dabdd3fbc6fdebb3e9bd9b1d0d178fe7beface
Cr-Commit-Position: refs/heads/master@{#12073}
==========

[commit-bot: I haz the power, 2016-03-21 11:16:01]

Patchset 3 (id:??) landed as
https://crrev.com/c5dabdd3fbc6fdebb3e9bd9b1d0d178fe7beface
Cr-Commit-Position: refs/heads/master@{#12073}