Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by minyue-webrtc Modified:
4 years, 9 months ago Reviewers:
peah-webrtc CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFixing UpdateLevel function in AEC.
From an earlier CL, we start to feed UpdateLevel() with power instead of energy. I found that UpdateLevel() is still taking the input as energy and normalize it. This CL fixes this.
The earlier CL is
https://codereview.webrtc.org/1542573002/
BUG=
Committed: https://crrev.com/6a85d3450ca4b480cdc41115ed911ecebbcbd882
Cr-Commit-Position: refs/heads/master@{#12084}
Patch Set 1 #
Created: 4 years, 9 months ago
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Fixing UpdateLevel function in AEC. BUG= ========== to ========== Fixing UpdateLevel function in AEC. From an earlier CL, we start to feed UpdateLevel() with power instead of energy. I found that UpdateLevel() is still taking the input as energy and normalize it. This CL fixes this. The earlier CL is https://codereview.webrtc.org/1542573002/ BUG= ==========
minyue@webrtc.org changed reviewers: + peah@webrtc.org
Hi Per, Here is a small CL. Would you review?
On 2016/03/17 09:32:41, minyue-webrtc wrote: > Hi Per, > > Here is a small CL. Would you review? Nice! lgtm
The CQ bit was checked by minyue@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810773003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by minyue@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810773003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
The CQ bit was checked by minyue@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810773003/1
Message was sent while issue was closed.
Description was changed from ========== Fixing UpdateLevel function in AEC. From an earlier CL, we start to feed UpdateLevel() with power instead of energy. I found that UpdateLevel() is still taking the input as energy and normalize it. This CL fixes this. The earlier CL is https://codereview.webrtc.org/1542573002/ BUG= ========== to ========== Fixing UpdateLevel function in AEC. From an earlier CL, we start to feed UpdateLevel() with power instead of energy. I found that UpdateLevel() is still taking the input as energy and normalize it. This CL fixes this. The earlier CL is https://codereview.webrtc.org/1542573002/ BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fixing UpdateLevel function in AEC. From an earlier CL, we start to feed UpdateLevel() with power instead of energy. I found that UpdateLevel() is still taking the input as energy and normalize it. This CL fixes this. The earlier CL is https://codereview.webrtc.org/1542573002/ BUG= ========== to ========== Fixing UpdateLevel function in AEC. From an earlier CL, we start to feed UpdateLevel() with power instead of energy. I found that UpdateLevel() is still taking the input as energy and normalize it. This CL fixes this. The earlier CL is https://codereview.webrtc.org/1542573002/ BUG= Committed: https://crrev.com/6a85d3450ca4b480cdc41115ed911ecebbcbd882 Cr-Commit-Position: refs/heads/master@{#12084} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6a85d3450ca4b480cdc41115ed911ecebbcbd882 Cr-Commit-Position: refs/heads/master@{#12084} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
