Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1810463002: Adding DebugDumpReplayer. (Closed)

Created:
4 years, 9 months ago by minyue-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding DebugDumpReplayer. It would be good to have a dedicated DebugDumpReplayer. There is one but it hides itself in DebugDumpTest. This CL is to separate it out. BUG= Committed: https://crrev.com/0de1c1374c4dba65ade1ec96f839dbd5bc620e3e Cr-Commit-Position: refs/heads/master@{#12029}

Patch Set 1 #

Patch Set 2 : actual change #

Total comments: 1

Patch Set 3 : a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -229 lines) Patch
A webrtc/modules/audio_processing/test/debug_dump_replayer.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/debug_dump_replayer.cc View 1 2 1 chunk +266 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 1 2 chunks +22 lines, -229 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
minyue-webrtc
Hi Henrik, Would you review this CL? Since debug_dump_replayer.h/cc is separated from debug_dump_test.cc, Patch set ...
4 years, 9 months ago (2016-03-16 09:44:02 UTC) #3
hlundin-webrtc
Nice! LGTM. https://codereview.webrtc.org/1810463002/diff/20001/webrtc/modules/audio_processing/test/debug_dump_replayer.cc File webrtc/modules/audio_processing/test/debug_dump_replayer.cc (right): https://codereview.webrtc.org/1810463002/diff/20001/webrtc/modules/audio_processing/test/debug_dump_replayer.cc#newcode78 webrtc/modules/audio_processing/test/debug_dump_replayer.cc:78: // We do not expect receive UNKNOWN ...
4 years, 9 months ago (2016-03-16 13:30:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810463002/40001
4 years, 9 months ago (2016-03-16 14:55:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 9 months ago (2016-03-16 16:56:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810463002/40001
4 years, 9 months ago (2016-03-17 06:29:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/9818)
4 years, 9 months ago (2016-03-17 07:20:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810463002/40001
4 years, 9 months ago (2016-03-17 08:36:21 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 09:39:34 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 09:39:46 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0de1c1374c4dba65ade1ec96f839dbd5bc620e3e
Cr-Commit-Position: refs/heads/master@{#12029}

Powered by Google App Engine
This is Rietveld 408576698