webrtc/voice_engine/transmit_mixer.cc - Issue 1810413002: Avoid clicks when muting/unmuting a voe::Channel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/transmit_mixer.cc

Issue 1810413002: Avoid clicks when muting/unmuting a voe::Channel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: removed commented out code Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/voice_engine/transmit_mixer.cc

diff --git a/webrtc/voice_engine/transmit_mixer.cc b/webrtc/voice_engine/transmit_mixer.cc

index 873fe39d1531dd4cdd9f9bce1ffc8ba4f24c39ed..be6297287b8bef28e06b654923f2d2c8be483669 100644

--- a/webrtc/voice_engine/transmit_mixer.cc

+++ b/webrtc/voice_engine/transmit_mixer.cc

@@ -359,10 +359,7 @@ TransmitMixer::PrepareDemux(const void* audioSamples,

#endif

// --- Mute signal

- if (_mute)

- {

- AudioFrameOperations::Mute(_audioFrame);

- }

peah-webrtc 2016/03/24 07:04:54 Sorry for the late comment on this, but why is the

the sun 2016/03/24 09:33:15 Exactly.

+ AudioFrameOperations::Mute(&_audioFrame, _mute, _mute);

// --- Mix with file (does not affect the mixing frequency)

if (_filePlaying)

« no previous file with comments | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/voe_volume_control_impl.cc » ('j') | no next file with comments »