Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/voice_engine/transmit_mixer.cc

Issue 1810413002: Avoid clicks when muting/unmuting a voe::Channel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/voice_engine/channel.cc ('K') | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/voe_volume_control_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/transmit_mixer.cc
diff --git a/webrtc/voice_engine/transmit_mixer.cc b/webrtc/voice_engine/transmit_mixer.cc
index 873fe39d1531dd4cdd9f9bce1ffc8ba4f24c39ed..be6297287b8bef28e06b654923f2d2c8be483669 100644
--- a/webrtc/voice_engine/transmit_mixer.cc
+++ b/webrtc/voice_engine/transmit_mixer.cc
@@ -359,10 +359,7 @@ TransmitMixer::PrepareDemux(const void* audioSamples,
#endif
// --- Mute signal
- if (_mute)
- {
- AudioFrameOperations::Mute(_audioFrame);
- }
+ AudioFrameOperations::Mute(&_audioFrame, _mute, _mute);
tlegrand-webrtc 2016/03/23 13:42:41 There won't be any fading here, right?
the sun 2016/03/23 14:25:59 Correct.
// --- Mix with file (does not affect the mixing frequency)
if (_filePlaying)
« webrtc/voice_engine/channel.cc ('K') | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/voe_volume_control_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698