Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: webrtc/modules/utility/include/audio_frame_operations.h

Issue 1810413002: Avoid clicks when muting/unmuting a voe::Channel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/utility/include/audio_frame_operations.h
diff --git a/webrtc/modules/utility/include/audio_frame_operations.h b/webrtc/modules/utility/include/audio_frame_operations.h
index 1551d8689422f50760ca5e5bcc53027bcfc22473..d34bb3efb00bab8b06efa7402834b847e3c12df1 100644
--- a/webrtc/modules/utility/include/audio_frame_operations.h
+++ b/webrtc/modules/utility/include/audio_frame_operations.h
@@ -46,7 +46,7 @@ class AudioFrameOperations {
static void SwapStereoChannels(AudioFrame* frame);
// Zeros out the audio and sets |frame.energy| to zero.
tlegrand-webrtc 2016/03/23 13:42:41 Is the function called both for mute and unmute? C
the sun 2016/03/23 14:25:59 Done.
- static void Mute(AudioFrame& frame);
+ static void Mute(AudioFrame* frame, bool start_muted, bool end_muted);
peah-webrtc 2016/03/23 15:57:04 Please add documentation of the start_muted and en
the sun 2016/03/23 21:30:52 I've renamed them and added documentation.
static int Scale(float left, float right, AudioFrame& frame);

Powered by Google App Engine
This is Rietveld 408576698