webrtc/modules/utility/include/audio_frame_operations.h - Issue 1810413002: Avoid clicks when muting/unmuting a voe::Channel.

Side by Side Diff: webrtc/modules/utility/include/audio_frame_operations.h

Issue 1810413002: Avoid clicks when muting/unmuting a voe::Channel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/modules/include/module_common_types.h ('k') | webrtc/modules/utility/source/audio_frame_operations.cc » ('j') | webrtc/modules/utility/source/audio_frame_operations.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 27 matching lines...) Expand all Loading...
38 static void StereoToMono(const int16_t* src_audio, size_t samples_per_channel,	38 static void StereoToMono(const int16_t* src_audio, size_t samples_per_channel,

39 int16_t* dst_audio);	39 int16_t* dst_audio);

40 // \|frame.num_channels_\| will be updated. This version checks that	40 // \|frame.num_channels_\| will be updated. This version checks that

41 // \|num_channels_\| is stereo.	41 // \|num_channels_\| is stereo.

42 static int StereoToMono(AudioFrame* frame);	42 static int StereoToMono(AudioFrame* frame);

43	43

44 // Swap the left and right channels of \|frame\|. Fails silently if \|frame\| is	44 // Swap the left and right channels of \|frame\|. Fails silently if \|frame\| is

45 // not stereo.	45 // not stereo.

46 static void SwapStereoChannels(AudioFrame* frame);	46 static void SwapStereoChannels(AudioFrame* frame);

47	47

48 // Zeros out the audio and sets \|frame.energy\| to zero.	48 // Zeros out the audio and sets \|frame.energy\| to zero.
	tlegrand-webrtc 2016/03/23 13:42:41 Is the function called both for mute and unmute? C Is the function called both for mute and unmute? Change name? The comment should be updated, saying something like "faded to/from zero"? the sun 2016/03/23 14:25:59 Done. Show quoted text On 2016/03/23 13:42:41, tlegrand-webrtc wrote: > Is the function called both for mute and unmute? Change name? > > The comment should be updated, saying something like "faded to/from zero"? Done.
49 static void Mute(AudioFrame& frame);	49 static void Mute(AudioFrame* frame, bool start_muted, bool end_muted);
	peah-webrtc 2016/03/23 15:57:04 Please add documentation of the start_muted and en Please add documentation of the start_muted and end_muted parameters. To me current names are quite general and a bit ambiguous and I think either clear documentation, or other more describing variable names are needed. the sun 2016/03/23 21:30:52 I've renamed them and added documentation. Show quoted text On 2016/03/23 15:57:04, peah-webrtc wrote: > Please add documentation of the start_muted and end_muted parameters. To me > current names are quite general and a bit ambiguous and I think either clear > documentation, or other more describing variable names are needed. I've renamed them and added documentation.
50	50

51 static int Scale(float left, float right, AudioFrame& frame);	51 static int Scale(float left, float right, AudioFrame& frame);

52	52

53 static int ScaleWithSat(float scale, AudioFrame& frame);	53 static int ScaleWithSat(float scale, AudioFrame& frame);

54 };	54 };

55	55

56 } // namespace webrtc	56 } // namespace webrtc

57	57

58 #endif // #ifndef WEBRTC_MODULES_UTILITY_INCLUDE_AUDIO_FRAME_OPERATIONS_H_	58 #endif // #ifndef WEBRTC_MODULES_UTILITY_INCLUDE_AUDIO_FRAME_OPERATIONS_H_

OLD	NEW