Added a bitexactness test for the echo canceller in the audio processing module.

Added a bitexactness test for the echo canceller in the audio processing module.

BUG=webrtc:5337
Committed: https://crrev.com/7c448e1a384224aa16a21715e83574f3f553b730
Cr-Commit-Position: refs/heads/master@{#12068}

[peah-webrtc, 2016-03-18 06:20:12]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2016-03-18 06:20:43]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-03-18 08:17:47]

LGTM, with a few minor comments.

https://codereview.webrtc.org/1809613002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/echo_cancellation_unittest.cc (right):

https://codereview.webrtc.org/1809613002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_cancellation_unittest.cc:29:
static_cast<EchoCancellation*>(echo_canceller)->Enable(true);
Consider:
EchoCancellation* ec = static_cast<EchoCancellation*>(echo_canceller);
ec->Enable(true);
...

You decide if it makes the code any prettier.

https://codereview.webrtc.org/1809613002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_cancellation_unittest.cc:56:
static_cast<EchoCancellation*>(echo_canceller)
Does this have to be set for every frame processed?

https://codereview.webrtc.org/1809613002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_cancellation_unittest.cc:81: int
samples_per_channel = rtc::CheckedDivExact(sample_rate_hz, 100);
const

https://codereview.webrtc.org/1809613002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_cancellation_unittest.cc:120: const float
kTolerance = 1.0f / 32768.0f;
Move to just before the line where it is used.

https://codereview.webrtc.org/1809613002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_cancellation_unittest.cc:121:
EXPECT_EQ(stream_has_echo_reference, stream_has_echo);
EXPECT_EQ(stream_has_echo_reference,
static_cast<EchoCancellation*>(&echo_canceller)->stream_has_echo());

[peah-webrtc, 2016-03-20 17:46:52]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-20 17:46:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809613002/40001

[commit-bot: I haz the power, 2016-03-20 17:59:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-20 17:59:47]

Dry run: Try jobs failed on following builders:
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/13679)

[peah-webrtc, 2016-03-20 21:28:27]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-03-20 21:28:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1809613002/#ps60001 (title:
"Changes in response to reviewer comments and changed test vectors")

[commit-bot: I haz the power, 2016-03-20 21:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809613002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809613002/60001

[commit-bot: I haz the power, 2016-03-21 00:22:25]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-21 00:22:35]

Description was changed from

==========
Added a bitexactness test for the echo canceller in the audio processing module.

BUG=webrtc:5337
==========

to

==========
Added a bitexactness test for the echo canceller in the audio processing module.

BUG=webrtc:5337

Committed: https://crrev.com/7c448e1a384224aa16a21715e83574f3f553b730
Cr-Commit-Position: refs/heads/master@{#12068}
==========

[commit-bot: I haz the power, 2016-03-21 00:22:37]

Patchset 3 (id:??) landed as
https://crrev.com/7c448e1a384224aa16a21715e83574f3f553b730
Cr-Commit-Position: refs/heads/master@{#12068}

[peah-webrtc, 2016-03-21 09:20:39]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.webrtc.org/1824583003/ by peah@webrtc.org.

The reason for reverting is: The tests in the CL are failing on the bots in the
Webrtc Waterfall (allthough they did not fail on the commit bots). I will
therefore revise and reland the test..