Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1809103002: Disable tests due to issue 5659. (Closed)

Created:
4 years, 9 months ago by stefan-webrtc
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable tests due to issue 5659. TBR=kjellander@webrtc.org BUG=webrtc:5659 Committed: https://crrev.com/55d6e7ca5f685af32737c460687be39f8eb7b9e2 Cr-Commit-Position: refs/heads/master@{#12035}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -9 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 10 chunks +85 lines, -8 lines 3 comments Download

Messages

Total messages: 11 (5 generated)
stefan-webrtc
4 years, 9 months ago (2016-03-17 15:15:43 UTC) #2
stefan-webrtc
Committed patchset #1 (id:1) manually as 55d6e7ca5f685af32737c460687be39f8eb7b9e2 (presubmit successful).
4 years, 9 months ago (2016-03-17 15:27:02 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55d6e7ca5f685af32737c460687be39f8eb7b9e2 Cr-Commit-Position: refs/heads/master@{#12035}
4 years, 9 months ago (2016-03-17 15:27:04 UTC) #7
torbjorng (webrtc)
https://codereview.webrtc.org/1809103002/diff/1/webrtc/api/peerconnectioninterface_unittest.cc File webrtc/api/peerconnectioninterface_unittest.cc (right): https://codereview.webrtc.org/1809103002/diff/1/webrtc/api/peerconnectioninterface_unittest.cc#newcode2044 webrtc/api/peerconnectioninterface_unittest.cc:2044: #define MAYBE_SdpWithoutMsidCreatesDefaultStream \ MAYBE_SdpWithoutMsidCreatesDefaultStream is not used. https://codereview.webrtc.org/1809103002/diff/1/webrtc/api/peerconnectioninterface_unittest.cc#newcode2169 webrtc/api/peerconnectioninterface_unittest.cc:2169: ...
4 years, 9 months ago (2016-03-17 15:59:46 UTC) #9
stefan-webrtc
https://codereview.webrtc.org/1809103002/diff/1/webrtc/api/peerconnectioninterface_unittest.cc File webrtc/api/peerconnectioninterface_unittest.cc (right): https://codereview.webrtc.org/1809103002/diff/1/webrtc/api/peerconnectioninterface_unittest.cc#newcode2044 webrtc/api/peerconnectioninterface_unittest.cc:2044: #define MAYBE_SdpWithoutMsidCreatesDefaultStream \ On 2016/03/17 15:59:45, torbjorng (webrtc) wrote: ...
4 years, 9 months ago (2016-03-17 16:29:57 UTC) #10
kjellander_webrtc
4 years, 9 months ago (2016-03-17 20:45:37 UTC) #11
Message was sent while issue was closed.
In addition to Torbjörn's comments I think WEBRTC_WIN is the preferred define.

Powered by Google App Engine
This is Rietveld 408576698