Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1809053002: Delete empty API files and cleaned up includes. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
AlexG, nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete empty API files and cleaned up includes. TBR=glaznev@webrtc.org BUG=webrtc:5426 Committed: https://crrev.com/c9022f508644dc33c01b05cb22ebfc2be145d6b2 Cr-Commit-Position: refs/heads/master@{#12039}

Patch Set 1 #

Total comments: 1

Patch Set 2 : IOS build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -165 lines) Patch
M talk/app/webrtc/objc/RTCPeerConnectionFactory.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCVideoCapturer+Internal.h View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCVideoSource+Internal.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/api.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCVideoSource+Private.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/remotevideocapturer.h View 1 chunk +0 lines, -16 lines 0 comments Download
D webrtc/api/remotevideocapturer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/api/rtpsender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/videosource.h View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/api/videosource.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/api/videosourceinterface.h View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/api/videosourceproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/videotrack.h View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/api/videotrackrenderers.h View 1 chunk +0 lines, -16 lines 0 comments Download
D webrtc/api/videotrackrenderers.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/api/videotracksource.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/conductor.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/media/base/capturemanager.h View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/media/base/capturemanager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/media/base/capturerenderadapter.h View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/media/base/capturerenderadapter.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
perkj_webrtc
Please?
4 years, 9 months ago (2016-03-17 12:02:16 UTC) #2
nisse-webrtc
lgtm https://codereview.webrtc.org/1809053002/diff/1/webrtc/api/objc/RTCVideoSource+Private.h File webrtc/api/objc/RTCVideoSource+Private.h (left): https://codereview.webrtc.org/1809053002/diff/1/webrtc/api/objc/RTCVideoSource+Private.h#oldcode10 webrtc/api/objc/RTCVideoSource+Private.h:10: Beware that there's likely another copy under talk, ...
4 years, 9 months ago (2016-03-17 12:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809053002/20001
4 years, 9 months ago (2016-03-17 14:42:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4209)
4 years, 9 months ago (2016-03-17 14:52:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809053002/20001
4 years, 9 months ago (2016-03-17 15:51:48 UTC) #12
AlexG
lgtm
4 years, 9 months ago (2016-03-17 16:48:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 16:57:33 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c9022f508644dc33c01b05cb22ebfc2be145d6b2 Cr-Commit-Position: refs/heads/master@{#12039}
4 years, 9 months ago (2016-03-17 16:57:40 UTC) #17
Taylor Brandstetter
4 years, 9 months ago (2016-03-17 22:03:15 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1813083002/ by deadbeef@webrtc.org.

The reason for reverting is: Breaks Chromium build. Need to remove the
references to the obsolete header files from Chromium and reland..

Powered by Google App Engine
This is Rietveld 408576698