Remove code interfacing legacy openssl.

Remove code interfacing legacy openssl.

BUG=webrtc:5664
Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}

[torbjorng (webrtc), 2016-03-16 14:50:05]

The CQ bit was checked by torbjorng@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 14:50:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808763002/1

[torbjorng (webrtc), 2016-03-16 15:48:56]

torbjorng@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2016-03-16 15:57:10]

are there any gyp/gn files that need updating?

[torbjorng (webrtc), 2016-03-16 16:14:03]

Shouldn't be. (The OPENSSL_IS_BORINGSSL symbol is defined by boringssl's
includes, not by our build files.)

[tommi, 2016-03-16 16:23:55]

lgtm

[torbjorng (webrtc), 2016-03-16 16:35:09]

The CQ bit was checked by torbjorng@webrtc.org

[torbjorng (webrtc), 2016-03-16 16:35:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1808763002/#ps20001 (title:
"Fold OPENSSL_VERSION_NUMBER tests")

[commit-bot: I haz the power, 2016-03-16 16:35:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808763002/20001

[commit-bot: I haz the power, 2016-03-16 16:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 16:58:49]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/9894)

[davidben_webrtc, 2016-03-16 17:45:46]

davidben@webrtc.org changed reviewers:
+ davidben@webrtc.org

[davidben_webrtc, 2016-03-16 17:45:47]

Thank you!!

https://codereview.webrtc.org/1808763002/diff/20001/webrtc/base/openssladapte...
File webrtc/base/openssladapter.cc (right):

https://codereview.webrtc.org/1808763002/diff/20001/webrtc/base/openssladapte...
webrtc/base/openssladapter.cc:156: return false;
You can also use CRYPTO_library_init which is all SSL_library_init ever calls
CRYPTO_library_init in BoringSSL and returns one.  Then you don't need to worry
about this failing.

https://boringssl.googlesource.com/boringssl/+/HEAD/PORTING.md#Initialization
https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#S...
https://commondatastorage.googleapis.com/chromium-boringssl-docs/crypto.h.htm...

(I'm hoping I can also get rid of the need for CRYPTO_library_init, but we'll
see.)

https://codereview.webrtc.org/1808763002/diff/20001/webrtc/base/openssladapte...
webrtc/base/openssladapter.cc:159: SSL_load_error_strings();
By the way, none of these four functions are necessary either. Error strings are
just const tables rather than hash tables in BoringSSL.

[torbjorng (webrtc), 2016-03-17 16:37:51]

The CQ bit was checked by torbjorng@webrtc.org

[torbjorng (webrtc), 2016-03-17 16:37:52]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1808763002/#ps40001 (title:
"Further simplifications with boringssl")

[commit-bot: I haz the power, 2016-03-17 16:37:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808763002/40001

[commit-bot: I haz the power, 2016-03-17 18:53:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 18:53:27]

Description was changed from

==========
Remove code interfacing legacy openssl.

BUG=
==========

to

==========
Remove code interfacing legacy openssl.

BUG=

Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}
==========

[commit-bot: I haz the power, 2016-03-17 18:53:28]

Patchset 3 (id:??) landed as
https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}

[torbjorng (webrtc), 2016-03-17 19:15:03]

Description was changed from

==========
Remove code interfacing legacy openssl.

BUG=

Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}
==========

to

==========
Remove code interfacing legacy openssl.

BUG=5664

Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}
==========

[torbjorng (webrtc), 2016-03-17 19:15:31]

Description was changed from

==========
Remove code interfacing legacy openssl.

BUG=5664

Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}
==========

to

==========
Remove code interfacing legacy openssl.

BUG=webrtc:5664

Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
Cr-Commit-Position: refs/heads/master@{#12041}
==========

[torbjorng (webrtc), 2016-03-24 11:33:24]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1828773003/ by torbjorng@webrtc.org.

The reason for reverting is: We will make it possible to link to BoringSSL for
WebRTC's usages of the crypto APIs and OpenSSL for other usages in the same
binary. Once that is completed, we will reland this..