webrtc/api/peerconnection_unittest.cc - Issue 1808643005: Truly disable tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnection_unittest.cc

Issue 1808643005: Truly disable tests. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comments addressed. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnection_unittest.cc

diff --git a/webrtc/api/peerconnection_unittest.cc b/webrtc/api/peerconnection_unittest.cc

index dcffd1330f11cd483b1fc19d33f9775dc18d0a96..fbaeaffb120153a4f6284c5fa3aefca019ac4340 100644

--- a/webrtc/api/peerconnection_unittest.cc

+++ b/webrtc/api/peerconnection_unittest.cc

@@ -1779,7 +1779,7 @@ TEST_F(P2PTestConductor, AddDataChannelAfterRenegotiation) {

// negotiation is completed without error.

#ifdef HAVE_SCTP

// Disabled on Win dbg: https://bugs.chromium.org/p/webrtc/issues/detail?id=5659

-#if defined(WIN) && defined(_DEBUG)

+#if defined(WEBRTC_WIN) && defined(_DEBUG)

#define MAYBE_CreateOfferWithSctpDataChannel \

DISABLED_CreateOfferWithSctpDataChannel

#else

« no previous file with comments | « no previous file | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »