Truly disable tests.

webrtc/api/peerconnection_unittest.cc

Index: webrtc/api/peerconnection_unittest.cc
diff --git a/webrtc/api/peerconnection_unittest.cc b/webrtc/api/peerconnection_unittest.cc
index dcffd1330f11cd483b1fc19d33f9775dc18d0a96..b30fd06cf160cb60a0f8524dfde184154e9343dd 100644
--- a/webrtc/api/peerconnection_unittest.cc
+++ b/webrtc/api/peerconnection_unittest.cc
@@ -1779,7 +1779,7 @@ TEST_F(P2PTestConductor, AddDataChannelAfterRenegotiation) {
 // negotiation is completed without error.
 #ifdef HAVE_SCTP
 // Disabled on Win dbg: https://bugs.chromium.org/p/webrtc/issues/detail?id=5659
-#if defined(WIN) && defined(_DEBUG)
+#if defined(WIN) && !defined(NDEBUG)

[kjellander_webrtc, 2016/03/17 20:52:34]

Why inverse the NDEBUG check instead of _DEBUG?

Both are clearly set in
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
but I think double-negations are harder to read. I'm not even 100% it's set on
Windows, by looking at the GYP code in there.

[kjellander_webrtc, 2016/03/17 20:52:34]

Use WEBRTC_WIN instead of WIN. Applies to whole CL.

[stefan-webrtc, 2016/03/17 21:07:15]

The previous CL didn't work, as The previous CL didn't work (see
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug). Not sure
why, and I didn't have time to investigate in detail. I however tried using
!NDEBUG on linux and that did work, so I assumed that was the problem. Maybe the
true problem was WIN vs. WEBRTC_WIN?

Btw, any clue why the try bot doesn't trigger the issue we're trying to hide? I
thought it would, that's why I submitted the previous CL.

[kjellander_webrtc, 2016/03/18 04:49:10]

I'm sorry you had to waste so much time on this. I also can't explain the trybot
behavior (see previous reply).
I don't know in detail which defines are set so I cannot guarantee anything
without local testing.
I wouldn't dare to trust that all defines are equal for Linux and Windows
though, since the build/common.gypi is quite hard to read. 
See previous reply.

[stefan-webrtc, 2016/03/18 08:07:36]

Going for WEBRTC_WIN and _DEBUG.

 #define MAYBE_CreateOfferWithSctpDataChannel \
   DISABLED_CreateOfferWithSctpDataChannel
 #else