Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1808573002: Revert of Add check_deps rules in DEPS files. (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add check_deps rules in DEPS files. (patchset #2 id:60001 of https://codereview.webrtc.org/1796413002/ ) Reason for revert: The openmax_dl include change breaks downstream projects. Original issue's description: > Add check_deps rules in DEPS files. > > Add fine-grained check_deps rules for all of WebRTC. > This will help both maintaining sane dependencies and provides a way > to visualize dependency graphs using the buildtools/checkdeps/graphdeps.py script. > > Example: > buildtools/checkdeps/graphdeps.py --root=. --format=png \ > --out=./webrtc.png --incl='^webrtc/modules/bitrate_controller->' \ > --excl='chromium|base|external|testing|webrtc/test|\.h$|\.cc$' > > will produce a neat webrtc.png image showcasing the dependencies > (according to the DEPS file) for the bitrate_controller module. > Some dependencies are filtered out for readability. > > BUG=webrtc:5623 > TESTED=Passing runs using: > buildtools/checkdeps/checkdeps.py --root=. talk > buildtools/checkdeps/checkdeps.py --root=. webrtc > > R=tommi@webrtc.org > > Committed: https://crrev.com/086f851b7b9b4bcbd4fe507c3bf83b760bd7f4d9 > Cr-Commit-Position: refs/heads/master@{#12008} TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5623 Committed: https://crrev.com/56cf60e71719e111ce02dd9832b0ff85bcc153a9 Cr-Commit-Position: refs/heads/master@{#12009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -348 lines) Patch
M DEPS View 1 chunk +19 lines, -0 lines 0 comments Download
D talk/app/webrtc/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/DEPS View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/api/DEPS View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/audio/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D webrtc/base/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/call/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/common_audio/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/common_audio/real_fourier_openmax.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/common_video/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/examples/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/libjingle/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
A webrtc/libjingle/xmpp/chatroommodule_unittest.cc View 1 chunk +280 lines, -0 lines 0 comments Download
D webrtc/media/DEPS View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/modules/audio_conference_mixer/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/audio_device/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/modules/audio_processing/DEPS View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/mock_agc.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/bitrate_controller/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/congestion_controller/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/desktop_capture/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/include/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/media_file/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/pacing/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/remote_bitrate_estimator/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D webrtc/modules/rtp_rtcp/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/utility/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/video_capture/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 chunk +2 lines, -1 line 0 comments Download
D webrtc/modules/video_processing/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/video_render/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/p2p/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/pc/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/sound/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/system_wrappers/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/test/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/tools/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/video/DEPS View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/voice_engine/DEPS View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
Created Revert of Add check_deps rules in DEPS files.
4 years, 9 months ago (2016-03-16 00:40:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808573002/1
4 years, 9 months ago (2016-03-16 00:40:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 00:41:05 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 00:41:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56cf60e71719e111ce02dd9832b0ff85bcc153a9
Cr-Commit-Position: refs/heads/master@{#12009}

Powered by Google App Engine
This is Rietveld 408576698