Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1807673004: Revert of Revert opus memcheck suppression (Closed)

Created:
4 years, 9 months ago by stefan-webrtc
Modified:
4 years, 9 months ago
Reviewers:
flim-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Revert opus memcheck suppression (patchset #1 id:1 of https://codereview.webrtc.org/1801233002/ ) Reason for revert: Reverting since the memcheck bot still fails. Original issue's description: > Revert opus memcheck suppression > > BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651 > > Committed: https://crrev.com/f62d107aa7ad6fcf2bacec3c6eb4a16469ed2287 > Cr-Commit-Position: refs/heads/master@{#12012} TBR=flim@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651 Committed: https://crrev.com/0e2e5d994fc25f6a5ea649a9c9418690044448a7 Cr-Commit-Position: refs/heads/master@{#12017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
stefan-webrtc
Created Revert of Revert opus memcheck suppression
4 years, 9 months ago (2016-03-16 14:43:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807673004/1
4 years, 9 months ago (2016-03-16 14:43:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 14:43:34 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 14:43:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e2e5d994fc25f6a5ea649a9c9418690044448a7
Cr-Commit-Position: refs/heads/master@{#12017}

Powered by Google App Engine
This is Rietveld 408576698