Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1807193002: Fix confusing naming of static class variables (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix confusing naming of static class variables As suggested here: https://codereview.webrtc.org/1803833002/#msg8 Committed: https://crrev.com/b21379515a26a748c087cd38060fbfed0bb1dd4b Cr-Commit-Position: refs/heads/master@{#12036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M webrtc/base/optional_unittest.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-17 12:45:52 UTC) #2
tommi
lgtm thanks!
4 years, 9 months ago (2016-03-17 12:52:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807193002/1
4 years, 9 months ago (2016-03-17 12:52:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-17 14:34:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807193002/1
4 years, 9 months ago (2016-03-17 14:53:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 15:38:17 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 15:38:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b21379515a26a748c087cd38060fbfed0bb1dd4b
Cr-Commit-Position: refs/heads/master@{#12036}

Powered by Google App Engine
This is Rietveld 408576698