Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 1806603002: cleanup RTCPSender (Closed)

Created:
4 years, 9 months ago by danilchap
Modified:
4 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

cleanup RTCPSender rtc::scoped_ptr -> std::unique_ptr. CrticalSectionWrapper -> CriticalSection. assert -> DCHECK. removed unused headers. removed unused using. removed unused member field. BUG=webrtc:5520, webrtc:5565 R=åsapersson Committed: https://crrev.com/56036ffc45765a2fd6c849a87835b475cb608d9b Cr-Commit-Position: refs/heads/master@{#12091}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -103 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 6 chunks +21 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 38 chunks +64 lines, -82 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
danilchap
4 years, 9 months ago (2016-03-15 15:22:39 UTC) #1
åsapersson
lgtm
4 years, 9 months ago (2016-03-22 14:25:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806603002/20001
4 years, 9 months ago (2016-03-22 14:26:21 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/10691)
4 years, 9 months ago (2016-03-22 14:30:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806603002/40001
4 years, 9 months ago (2016-03-22 15:27:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-22 17:27:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806603002/40001
4 years, 9 months ago (2016-03-22 17:59:15 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 18:14:13 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 18:14:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56036ffc45765a2fd6c849a87835b475cb608d9b
Cr-Commit-Position: refs/heads/master@{#12091}

Powered by Google App Engine
This is Rietveld 408576698