Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h

Issue 1806073002: rtcp::SenderReport updated to use rtcp::CommonHeader for parsing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
index e26911abc3af24fa5cd00e2b4759fb0eabd98e74..956bc441cb3df08327ee2b736753d08a4d2984af 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
@@ -14,8 +14,8 @@
#include <vector>
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h"
-#include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
#include "webrtc/system_wrappers/include/ntp_time.h"
namespace webrtc {
@@ -26,11 +26,10 @@ class SenderReport : public RtcpPacket {
static const uint8_t kPacketType = 200;
SenderReport();
- virtual ~SenderReport() {}
+ ~SenderReport() override {}
// Parse assumes header is already parsed and validated.
- bool Parse(const RTCPUtility::RtcpCommonHeader& header,
- const uint8_t* payload); // Size of the payload is in the header.
+ bool Parse(const CommonHeader& packet);
void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }
void WithNtp(NtpTime ntp) { ntp_ = ntp; }
@@ -60,7 +59,7 @@ class SenderReport : public RtcpPacket {
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
- RtcpPacket::PacketReadyCallback* callback) const override;
+ PacketReadyCallback* callback) const override;
private:
static const size_t kMaxNumberOfReportBlocks = 0x1f;
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698