SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to the handler thread. If stopListening() is called before that Runnable is executed, the Runnable will set the listener after stopListening() has been called. Then the next call to startListening() will fail with "SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=5519
,b/27677772

Committed: https://crrev.com/d8ddb796e44b0773d3e6e65b6d1ee7b05d524129
Cr-Commit-Position: refs/heads/master@{#12030}

[magjed1, 2016-03-16 18:44:22]

Description was changed from

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=b/27677772
==========

to

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=b/27677772
==========

[magjed1, 2016-03-16 18:44:22]

magjed@google.com changed reviewers:
+ perkj@webrtc.org

[magjed1, 2016-03-17 08:21:49]

Description was changed from

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=b/27677772
==========

to

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=5519,b/27677772
==========

[magjed1, 2016-03-17 08:24:36]

magjed@google.com changed reviewers:
+ magjed@google.com

[magjed1, 2016-03-17 08:24:37]

perkj - Please take a look.

[perkj_webrtc, 2016-03-17 08:39:28]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-03-17 08:39:29]

lgtm

[commit-bot: I haz the power, 2016-03-17 08:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806013003/1

[magjed_webrtc, 2016-03-17 09:01:39]

magjed@webrtc.org changed reviewers:
- magjed@google.com

[commit-bot: I haz the power, 2016-03-17 10:13:45]

Description was changed from

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=5519,b/27677772
==========

to

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=5519,b/27677772
==========

[commit-bot: I haz the power, 2016-03-17 10:13:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 10:13:52]

Description was changed from

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=5519,b/27677772
==========

to

==========
SurfaceTextureHelper: Fix startListening()/stopListening() race

SurfaceTextureHelper.startListening() is asynchronous and posts a Runnable to
the handler thread. If stopListening() is called before that Runnable is
executed, the Runnable will set the listener after stopListening() has been
called. Then the next call to startListening() will fail with
"SurfaceTextureHelper listener has already been set."

This CL adds a test to reproduce this bug, and a fix.

BUG=5519,b/27677772

Committed: https://crrev.com/d8ddb796e44b0773d3e6e65b6d1ee7b05d524129
Cr-Commit-Position: refs/heads/master@{#12030}
==========

[commit-bot: I haz the power, 2016-03-17 10:13:53]

Patchset 1 (id:??) landed as
https://crrev.com/d8ddb796e44b0773d3e6e65b6d1ee7b05d524129
Cr-Commit-Position: refs/heads/master@{#12030}