Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1804333002: Reland "Add check_deps rules in DEPS files." (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Add check_deps rules in DEPS files." Relanding https://codereview.webrtc.org/1796413002/ without the change to the openmax_dl include path (which broke downstream code). TBR=tommi@webrtc.org BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc Committed: https://crrev.com/94a23f04afc715b42a1ac9d2abb8a2154af43f67 Cr-Commit-Position: refs/heads/master@{#12031}

Patch Set 1 #

Patch Set 2 : Rebased and updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -305 lines) Patch
M DEPS View 1 1 chunk +0 lines, -19 lines 0 comments Download
A talk/app/webrtc/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/DEPS View 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/api/DEPS View 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/audio/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/base/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A webrtc/call/DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/common_audio/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/common_video/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/examples/DEPS View 1 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/libjingle/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
D webrtc/libjingle/xmpp/chatroommodule_unittest.cc View 1 chunk +0 lines, -280 lines 0 comments Download
A webrtc/media/DEPS View 1 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/modules/audio_conference_mixer/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/audio_device/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/mock_agc.h View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/bitrate_controller/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/congestion_controller/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/desktop_capture/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/include/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/media_file/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/pacing/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/remote_bitrate_estimator/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/utility/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 2 chunks +1 line, -2 lines 0 comments Download
A webrtc/modules/video_processing/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/p2p/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/pc/DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/sound/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/system_wrappers/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/test/DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/tools/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/video/DEPS View 1 chunk +17 lines, -0 lines 0 comments Download
A webrtc/voice_engine/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
I have now checked with the downstream project that this doesn't break. No other changes ...
4 years, 9 months ago (2016-03-17 11:02:40 UTC) #5
kjellander_webrtc
On 2016/03/17 11:02:40, kjellander (webrtc) wrote: > I have now checked with the downstream project ...
4 years, 9 months ago (2016-03-17 11:05:29 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/94a23f04afc715b42a1ac9d2abb8a2154af43f67 Cr-Commit-Position: refs/heads/master@{#12031}
4 years, 9 months ago (2016-03-17 11:05:54 UTC) #9
kjellander_webrtc
4 years, 9 months ago (2016-03-17 11:05:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
94a23f04afc715b42a1ac9d2abb8a2154af43f67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698