Delete unused VideoCapturer statistics.

Delete unused VideoCapturer statistics.

It appears that the adapt_frame_drops, effects_frame_drops, and capturer_frame_time statistics are never used. They are collected by cricket::VideoCapturer, and copied into VideoSenderInfo by the VideoMediaChannel::GetStats method.

So delete the code to generate the statistics, and the VariableInfo template which had no other uses.

BUG=webrtc:5426
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/505945aed7dea44a35e88a715dbeffe27611449b

[nisse-webrtc, 2016-03-16 08:52:12]

Description was changed from

==========
Delete unused VideoCapturer statistics.

BUG=webrtc:5426
==========

to

==========
Delete unused VideoCapturer statistics.

It appears that the adapt_frame_drops, effects_frame_drops, and
capturer_frame_time statistics are never used. They are collected by
cricket::VideoCapturer, and copied into VideoSenderInfo by the
VideoMediaChannel::GetStats method.

So delete the code to generate the statistics, and the VariableInfo template
which had no other uses.

BUG=webrtc:5426
==========

[nisse-webrtc, 2016-03-16 08:52:12]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org, pthatcher@webrtc.org

[nisse-webrtc, 2016-03-16 08:52:35]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 08:52:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804133003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804133003/1

[commit-bot: I haz the power, 2016-03-16 08:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 08:55:07]

Dry run: Try jobs failed on following builders:
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/12156)

[nisse-webrtc, 2016-03-16 09:05:53]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 09:06:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804133003/20001

[commit-bot: I haz the power, 2016-03-16 09:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 09:08:17]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/8327)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/8241)
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/13523)

[pbos-webrtc, 2016-03-16 13:49:57]

lgtm

https://codereview.webrtc.org/1804133003/diff/20001/webrtc/api/objc/avfoundat...
File webrtc/api/objc/avfoundationvideocapturer.h (right):

https://codereview.webrtc.org/1804133003/diff/20001/webrtc/api/objc/avfoundat...
webrtc/api/objc/avfoundationvideocapturer.h:24: }
}  // namespace rtc

[nisse-webrtc, 2016-03-16 13:59:29]

Regarding the IOS failures, does anyone know why we have both

./webrtc/api/objc/avfoundationvideocapturer.mm
./talk/app/webrtc/objc/avfoundationvideocapturer.mm

It seems I added the 

#include "webrtc/base/thread.h"

to the new location in webrtc/api/objc, but it's the file in the old location
which is included in the ios builds.

[pthatcher1, 2016-03-16 15:12:22]

lgtm

I can't remember why we have two iOS directories.  I think it's one of those
"we've moving it and we can't break the old one right now" things.   tkchin@
will know/remember.

[nisse-webrtc, 2016-03-17 08:33:16]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 08:33:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804133003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804133003/40001

[nisse-webrtc, 2016-03-17 11:11:31]

The CQ bit was unchecked by nisse@webrtc.org

[nisse-webrtc, 2016-03-17 11:11:42]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-17 11:11:42]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1804133003/#ps40001 (title:
"Address nits. Update both copies of AVFoundationVideoCapturer.'")

[commit-bot: I haz the power, 2016-03-17 11:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804133003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804133003/40001

[nisse-webrtc, 2016-03-17 11:20:54]

Description was changed from

==========
Delete unused VideoCapturer statistics.

It appears that the adapt_frame_drops, effects_frame_drops, and
capturer_frame_time statistics are never used. They are collected by
cricket::VideoCapturer, and copied into VideoSenderInfo by the
VideoMediaChannel::GetStats method.

So delete the code to generate the statistics, and the VariableInfo template
which had no other uses.

BUG=webrtc:5426
==========

to

==========
Delete unused VideoCapturer statistics.

It appears that the adapt_frame_drops, effects_frame_drops, and
capturer_frame_time statistics are never used. They are collected by
cricket::VideoCapturer, and copied into VideoSenderInfo by the
VideoMediaChannel::GetStats method.

So delete the code to generate the statistics, and the VariableInfo template
which had no other uses.

BUG=webrtc:5426
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/505945aed7dea44a35e88a715...
==========

[commit-bot: I haz the power, 2016-03-17 11:20:55]

Description was changed from

==========
Delete unused VideoCapturer statistics.

It appears that the adapt_frame_drops, effects_frame_drops, and
capturer_frame_time statistics are never used. They are collected by
cricket::VideoCapturer, and copied into VideoSenderInfo by the
VideoMediaChannel::GetStats method.

So delete the code to generate the statistics, and the VariableInfo template
which had no other uses.

BUG=webrtc:5426
==========

to

==========
Delete unused VideoCapturer statistics.

It appears that the adapt_frame_drops, effects_frame_drops, and
capturer_frame_time statistics are never used. They are collected by
cricket::VideoCapturer, and copied into VideoSenderInfo by the
VideoMediaChannel::GetStats method.

So delete the code to generate the statistics, and the VariableInfo template
which had no other uses.

BUG=webrtc:5426
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/505945aed7dea44a35e88a715dbeffe27611449b
Cr-Commit-Position: refs/heads/master@{#12032}
==========

[commit-bot: I haz the power, 2016-03-17 11:20:56]

Patchset 3 (id:??) landed as
https://crrev.com/505945aed7dea44a35e88a715dbeffe27611449b
Cr-Commit-Position: refs/heads/master@{#12032}

[nisse-webrtc, 2016-03-17 11:20:56]

Committed patchset #3 (id:40001) manually as
505945aed7dea44a35e88a715dbeffe27611449b (presubmit successful).