Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: webrtc/base/optional_unittest.cc

Issue 1803833002: Stop using some scoped_ptr features that unique_ptr doesn't have (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: More review comments fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/httpserver.cc ('k') | webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/optional_unittest.cc
diff --git a/webrtc/base/optional_unittest.cc b/webrtc/base/optional_unittest.cc
index eabf091e17a024924d05c11c1a47ddb5733a10e9..9b9339e6f21d4cdda4baa8e97a017d7d648c9364 100644
--- a/webrtc/base/optional_unittest.cc
+++ b/webrtc/base/optional_unittest.cc
@@ -65,7 +65,7 @@ class Logger {
void Foo() { Log("Foo()"); }
void Foo() const { Log("Foo() const"); }
static rtc::scoped_ptr<std::vector<std::string>> Setup() {
- auto s = rtc_make_scoped_ptr(new std::vector<std::string>);
+ rtc::scoped_ptr<std::vector<std::string>> s(new std::vector<std::string>);
Logger::log_ = s.get();
tommi 2016/03/17 12:23:26 Do you mind removing the "Logger::" prefix where i
Logger::next_id_ = 0;
return s;
« no previous file with comments | « webrtc/base/httpserver.cc ('k') | webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698