Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: webrtc/p2p/base/dtlstransportchannel.cc

Issue 1803833002: Stop using some scoped_ptr features that unique_ptr doesn't have (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/dtlstransportchannel.cc
diff --git a/webrtc/p2p/base/dtlstransportchannel.cc b/webrtc/p2p/base/dtlstransportchannel.cc
index bbf3e5c484b0302672ea889665ec4ec0ac285134..cf86fb071fd0e0039fa5a90100a529c545d934c0 100644
--- a/webrtc/p2p/base/dtlstransportchannel.cc
+++ b/webrtc/p2p/base/dtlstransportchannel.cc
@@ -234,7 +234,7 @@ bool DtlsTransportChannelWrapper::SetRemoteFingerprint(
remote_fingerprint_value_ = std::move(remote_fingerprint_value);
remote_fingerprint_algorithm_ = digest_alg;
- bool reconnect = dtls_;
+ bool reconnect = !!dtls_;
tommi 2016/03/15 09:22:09 My preference is to not not not the dtls.
kwiberg-webrtc 2016/03/15 09:59:41 You complained about this an even number of times.
tommi (sloooow) - chröme 2016/03/15 16:49:00 I'd rather compare dtls_ to a value of the same ty
kwiberg-webrtc 2016/03/15 18:53:37 Still not convinced this is more readable, but OK.
if (!SetupDtls()) {
set_dtls_state(DTLS_TRANSPORT_FAILED);

Powered by Google App Engine
This is Rietveld 408576698