Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: webrtc/base/asyncudpsocket.cc

Issue 1803833002: Stop using some scoped_ptr features that unique_ptr doesn't have (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/httpserver.cc » ('j') | webrtc/base/httpserver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/asyncudpsocket.cc
diff --git a/webrtc/base/asyncudpsocket.cc b/webrtc/base/asyncudpsocket.cc
index 51a8fa0af0a2a0cbd4126cba9ffa5647b1c32d15..03f3ab970d942d290ab0845acf6d140e0e0e14cf 100644
--- a/webrtc/base/asyncudpsocket.cc
+++ b/webrtc/base/asyncudpsocket.cc
@@ -37,7 +37,7 @@ AsyncUDPSocket* AsyncUDPSocket::Create(SocketFactory* factory,
AsyncUDPSocket::AsyncUDPSocket(AsyncSocket* socket)
: socket_(socket) {
- ASSERT(socket_);
+ ASSERT(!!socket_);
tommi 2016/03/15 09:22:09 The double not is not always not so readable, exce
kwiberg-webrtc 2016/03/15 09:59:41 OK, will remove. (!!x is the standard C idiom for
tommi (sloooow) - chröme 2016/03/15 16:49:00 This isn't the first time I'm seeing it :)
kwiberg-webrtc 2016/03/15 18:53:37 And yet you acted confused...
tommi 2016/03/17 12:23:26 I guess I was rhetorically confused :)
size_ = BUF_SIZE;
buf_ = new char[size_];
« no previous file with comments | « no previous file | webrtc/base/httpserver.cc » ('j') | webrtc/base/httpserver.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698