Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: webrtc/base/optional_unittest.cc

Issue 1803833002: Stop using some scoped_ptr features that unique_ptr doesn't have (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/httpserver.cc ('k') | webrtc/p2p/base/dtlstransportchannel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 Log2("operator==", a, b); 58 Log2("operator==", a, b);
59 return a.origin_ == b.origin_; 59 return a.origin_ == b.origin_;
60 } 60 }
61 friend bool operator!=(const Logger& a, const Logger& b) { 61 friend bool operator!=(const Logger& a, const Logger& b) {
62 Log2("operator!=", a, b); 62 Log2("operator!=", a, b);
63 return a.origin_ != b.origin_; 63 return a.origin_ != b.origin_;
64 } 64 }
65 void Foo() { Log("Foo()"); } 65 void Foo() { Log("Foo()"); }
66 void Foo() const { Log("Foo() const"); } 66 void Foo() const { Log("Foo() const"); }
67 static rtc::scoped_ptr<std::vector<std::string>> Setup() { 67 static rtc::scoped_ptr<std::vector<std::string>> Setup() {
68 auto s = rtc_make_scoped_ptr(new std::vector<std::string>); 68 rtc::scoped_ptr<std::vector<std::string>> s(new std::vector<std::string>);
69 g_log = s.get(); 69 g_log = s.get();
70 g_next_id = 0; 70 g_next_id = 0;
71 return s; 71 return s;
72 } 72 }
73 73
74 private: 74 private:
75 int id_; 75 int id_;
76 int origin_; 76 int origin_;
77 static std::vector<std::string>* g_log; 77 static std::vector<std::string>* g_log;
78 static int g_next_id; 78 static int g_next_id;
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 "4:17. copy constructor (from 0:17)", "5:5. default constructor", 480 "4:17. copy constructor (from 0:17)", "5:5. default constructor",
481 "6:6. default constructor", "7:7. default constructor", "---", 481 "6:6. default constructor", "7:7. default constructor", "---",
482 "swap 2:42, 3:17", "swap 4:5, 5:17", "swap 6:7, 7:6", "---", 482 "swap 2:42, 3:17", "swap 4:5, 5:17", "swap 6:7, 7:6", "---",
483 "7:6. destructor", "6:7. destructor", "5:17. destructor", 483 "7:6. destructor", "6:7. destructor", "5:17. destructor",
484 "4:5. destructor", "3:17. destructor", "2:42. destructor", 484 "4:5. destructor", "3:17. destructor", "2:42. destructor",
485 "1:42. destructor", "0:17. destructor"), 485 "1:42. destructor", "0:17. destructor"),
486 *log); 486 *log);
487 } 487 }
488 488
489 } // namespace rtc 489 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/httpserver.cc ('k') | webrtc/p2p/base/dtlstransportchannel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698