Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1803433003: Removed the dependency on AudioProcessingImpl in EchoControlMobileImpl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Corrected the error code returned when the stream delay had not been set Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index 67dcd9004a8a683c9504cafb5668dce9c4cc98d5..24159939f3206113bb097b85e0d015d1f341feeb 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -170,7 +170,7 @@ AudioProcessingImpl::AudioProcessingImpl(const Config& config,
public_submodules_->echo_cancellation.reset(
new EchoCancellationImpl(this, &crit_render_, &crit_capture_));
public_submodules_->echo_control_mobile.reset(
- new EchoControlMobileImpl(this, &crit_render_, &crit_capture_));
+ new EchoControlMobileImpl(&crit_render_, &crit_capture_));
public_submodules_->gain_control.reset(
new GainControlImpl(this, &crit_capture_, &crit_capture_));
public_submodules_->high_pass_filter.reset(
@@ -706,8 +706,17 @@ int AudioProcessingImpl::ProcessStreamLocked() {
public_submodules_->intelligibility_enhancer->SetCaptureNoiseEstimate(
public_submodules_->noise_suppression->NoiseEstimate());
}
- RETURN_ON_ERR(
- public_submodules_->echo_control_mobile->ProcessCaptureAudio(ca));
+
+ // Ensure that the stream delay was set before the call to the
+ // AECM ProcessCaptureAudio function.
+ if (public_submodules_->echo_control_mobile->is_enabled() &&
+ !was_stream_delay_set()) {
+ return AudioProcessing::kStreamParameterNotSetError;
+ }
+
+ RETURN_ON_ERR(public_submodules_->echo_control_mobile->ProcessCaptureAudio(
+ ca, stream_delay_ms()));
+
public_submodules_->voice_detection->ProcessCaptureAudio(ca);
if (constants_.use_experimental_agc &&
@@ -1225,7 +1234,8 @@ void AudioProcessingImpl::InitializeGainController() {
}
void AudioProcessingImpl::InitializeEchoControlMobile() {
- public_submodules_->echo_control_mobile->Initialize();
+ public_submodules_->echo_control_mobile->Initialize(
+ proc_sample_rate_hz(), num_reverse_channels(), num_output_channels());
}
void AudioProcessingImpl::InitializeLevelEstimator() {

Powered by Google App Engine
This is Rietveld 408576698