Removed the dependency on AudioProcessingImpl in EchoControlMobileImpl

Removed the dependency on AudioProcessingImpl in EchoControlMobileImpl

BUG=webrtc:5351
Committed: https://crrev.com/253534d1bdb5d21670f355f0b553efec51c7adc6
Cr-Commit-Position: refs/heads/master@{#11995}

[peah-webrtc, 2016-03-14 07:34:20]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 07:34:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1803433003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1803433003/1

[commit-bot: I haz the power, 2016-03-14 07:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 07:41:55]

Dry run: Try jobs failed on following builders:
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/13488)

[peah-webrtc, 2016-03-15 06:31:01]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2016-03-15 06:33:15]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[peah-webrtc, 2016-03-15 07:00:41]

Found a wrong error code that was returned, but not caught in the tests. Now the
code is as it should though.

[hlundin-webrtc, 2016-03-15 07:29:43]

Nice, but...

https://codereview.webrtc.org/1803433003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/echo_control_mobile_impl.h (right):

https://codereview.webrtc.org/1803433003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_control_mobile_impl.h:86:
std::unique_ptr<StreamProperties> stream_properties_;
You are creating a member that is not set on construction, but requires the
caller to set it through the call to Initialize(). Meanwhile, the member is read
in several places inside the class without checking if it was ever set.

[hlundin-webrtc, 2016-03-15 07:53:38]

LGTM with one comment.

https://codereview.webrtc.org/1803433003/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/echo_control_mobile_impl.cc (right):

https://codereview.webrtc.org/1803433003/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_control_mobile_impl.cc:265:
RTC_DCHECK(stream_properties_);
Move the DCHECK to before line 256.

[peah-webrtc, 2016-03-15 08:18:31]

https://codereview.webrtc.org/1803433003/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/echo_control_mobile_impl.cc (right):

https://codereview.webrtc.org/1803433003/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/echo_control_mobile_impl.cc:265:
RTC_DCHECK(stream_properties_);
On 2016/03/15 07:53:38, hlundin-webrtc wrote:
> Move the DCHECK to before line 256.

Of course! :$ Good catch!

[peah-webrtc, 2016-03-15 10:04:02]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-03-15 10:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1803433003/#ps100001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-03-15 10:04:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1803433003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1803433003/100001

[commit-bot: I haz the power, 2016-03-15 11:32:33]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-03-15 11:32:43]

Description was changed from

==========
Removed the dependency on AudioProcessingImpl in EchoControlMobileImpl

BUG=webrtc:5351
==========

to

==========
Removed the dependency on AudioProcessingImpl in EchoControlMobileImpl

BUG=webrtc:5351

Committed: https://crrev.com/253534d1bdb5d21670f355f0b553efec51c7adc6
Cr-Commit-Position: refs/heads/master@{#11995}
==========

[commit-bot: I haz the power, 2016-03-15 11:32:44]

Patchset 5 (id:??) landed as
https://crrev.com/253534d1bdb5d21670f355f0b553efec51c7adc6
Cr-Commit-Position: refs/heads/master@{#11995}