Reset the BWE when the network changes

webrtc/base/networkroute.h

+/*
+ *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_BASE_NETWORK_ROUTE_H_
+#define WEBRTC_BASE_NETWORK_ROUTE_H_
+
+namespace cricket {

[pthatcher1, 2016/03/24 18:46:36]

It seems like this shouldn't be in base/.  We don't have a good place for things
that both network and media code depend on, but I don't think the network code
depends on this.  

It seems like this should go where MediaChannel::NetworkInterface is, which is
mediachannel.h  We can find a better home for it when we refactor
mediachannel.h.

[honghaiz3, 2016/03/24 22:37:11]

If we do that, call dir has to include webrtc/media, which is not allowed at
this moment. Not sure if it is a good idea to add that dependency. 

[pthatcher1, 2016/03/25 21:30:21]

Yeah, since the network code doesn't depend on the media code and the media code
doesn't depend on the network code, we need a third place to stick things that
both can depend on.  I hope someday we can have a "here's the interface/structs
the media stack needs from the network" that doesn't depend on the network code
or the media code.  But right now we don't have a place like that.

So, can you at least put a TODO here, something like:

TODO: Make a directory that describes the interfaces and structs that the media
code can rely on and the network code can implement, and both can depend on
that, but not depend on each other.  Then, move this file to that directory.

[honghaiz3, 2016/03/28 04:03:16]

Done. Thanks!

+
+struct NetworkRoute {
+  bool connected;
+  uint16_t local_network_id;
+  uint16_t remote_network_id;
+
+  NetworkRoute(): connected(false), local_network_id(0), remote_network_id(0) {}
+
+  // The route is connected if the local and remote network ids are provided.
+  NetworkRoute(uint16_t local_net_id, uint16_t remote_net_id)
+      : connected(true),
+        local_network_id(local_net_id),
+        remote_network_id(remote_net_id) {}
+
+  bool operator==(const NetworkRoute& nr) const {
+    return connected == nr.connected &&
+           local_network_id == nr.local_network_id &&
+           remote_network_id == nr.remote_network_id;
+  }
+
+  bool operator!=(const NetworkRoute& nr) const { return !(*this == nr); }
+};
+}  // namespace cricket
+
+#endif  // WEBRTC_BASE_NETWORK_ROUTE_H_