webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc - Issue 1802993002: Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc

Issue 1802993002: Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@voe_dtmf_7

Patch Set: Reanimate CreateAudioReceiver() with 5 params, to not break downstream code. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc

diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc

index 6c60bf1f6d1c48931ab64dfae88d3e1eb679a1bb..d4b364127360c28293c030d178f1c08ba3a8c842 100644

--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc

+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc

@@ -101,7 +101,7 @@ class RtpRtcpRtcpTest : public ::testing::Test {

rtp_feedback1_.reset(new TestRtpFeedback(module1));

rtp_receiver1_.reset(RtpReceiver::CreateAudioReceiver(

- &fake_clock, NULL, receiver, rtp_feedback1_.get(),

+ &fake_clock, receiver, rtp_feedback1_.get(),

rtp_payload_registry1_.get()));

configuration.receive_statistics = receive_statistics2_.get();

@@ -113,7 +113,7 @@ class RtpRtcpRtcpTest : public ::testing::Test {

rtp_feedback2_.reset(new TestRtpFeedback(module2));

rtp_receiver2_.reset(RtpReceiver::CreateAudioReceiver(

- &fake_clock, NULL, receiver, rtp_feedback2_.get(),

+ &fake_clock, receiver, rtp_feedback2_.get(),

rtp_payload_registry2_.get()));

transport1->SetSendModule(module2, rtp_payload_registry2_.get(),

« no previous file with comments | « webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc ('k') | webrtc/voice_engine/channel.cc » ('j') | no next file with comments »