Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 1802993002: Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@voe_dtmf_7
Patch Set: Reanimate CreateAudioReceiver() with 5 params, to not break downstream code. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 const char payloadName[RTP_PAYLOAD_NAME_SIZE], 210 const char payloadName[RTP_PAYLOAD_NAME_SIZE],
211 const int frequency, 211 const int frequency,
212 const size_t channels, 212 const size_t channels,
213 const uint32_t rate) = 0; 213 const uint32_t rate) = 0;
214 214
215 virtual void OnIncomingSSRCChanged(const uint32_t ssrc) = 0; 215 virtual void OnIncomingSSRCChanged(const uint32_t ssrc) = 0;
216 216
217 virtual void OnIncomingCSRCChanged(const uint32_t CSRC, const bool added) = 0; 217 virtual void OnIncomingCSRCChanged(const uint32_t CSRC, const bool added) = 0;
218 }; 218 };
219 219
220 class RtpAudioFeedback {
221 public:
222 virtual void OnPlayTelephoneEvent(const uint8_t event,
223 const uint16_t lengthMs,
224 const uint8_t volume) = 0;
225
226 protected:
227 virtual ~RtpAudioFeedback() {}
228 };
229
230 class RtcpIntraFrameObserver { 220 class RtcpIntraFrameObserver {
231 public: 221 public:
232 virtual void OnReceivedIntraFrameRequest(uint32_t ssrc) = 0; 222 virtual void OnReceivedIntraFrameRequest(uint32_t ssrc) = 0;
233 223
234 virtual void OnReceivedSLI(uint32_t ssrc, 224 virtual void OnReceivedSLI(uint32_t ssrc,
235 uint8_t picture_id) = 0; 225 uint8_t picture_id) = 0;
236 226
237 virtual void OnReceivedRPSI(uint32_t ssrc, 227 virtual void OnReceivedRPSI(uint32_t ssrc,
238 uint64_t picture_id) = 0; 228 uint64_t picture_id) = 0;
239 229
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 const size_t payloadSize, 340 const size_t payloadSize,
351 const WebRtcRTPHeader* rtpHeader) override { 341 const WebRtcRTPHeader* rtpHeader) override {
352 return 0; 342 return 0;
353 } 343 }
354 344
355 bool OnRecoveredPacket(const uint8_t* packet, size_t packet_length) override { 345 bool OnRecoveredPacket(const uint8_t* packet, size_t packet_length) override {
356 return true; 346 return true;
357 } 347 }
358 }; 348 };
359 349
360 // Null object version of RtpAudioFeedback.
361 class NullRtpAudioFeedback : public RtpAudioFeedback {
362 public:
363 virtual ~NullRtpAudioFeedback() {}
364
365 void OnPlayTelephoneEvent(const uint8_t event,
366 const uint16_t lengthMs,
367 const uint8_t volume) override {}
368 };
369
370 // Statistics about packet loss for a single directional connection. All values 350 // Statistics about packet loss for a single directional connection. All values
371 // are totals since the connection initiated. 351 // are totals since the connection initiated.
372 struct RtpPacketLossStats { 352 struct RtpPacketLossStats {
373 // The number of packets lost in events where no adjacent packets were also 353 // The number of packets lost in events where no adjacent packets were also
374 // lost. 354 // lost.
375 uint64_t single_packet_loss_count; 355 uint64_t single_packet_loss_count;
376 // The number of events in which more than one adjacent packet was lost. 356 // The number of events in which more than one adjacent packet was lost.
377 uint64_t multiple_packet_loss_event_count; 357 uint64_t multiple_packet_loss_event_count;
378 // The number of packets lost in events where more than one adjacent packet 358 // The number of packets lost in events where more than one adjacent packet
379 // was lost. 359 // was lost.
(...skipping 26 matching lines...) Expand all
406 class TransportSequenceNumberAllocator { 386 class TransportSequenceNumberAllocator {
407 public: 387 public:
408 TransportSequenceNumberAllocator() {} 388 TransportSequenceNumberAllocator() {}
409 virtual ~TransportSequenceNumberAllocator() {} 389 virtual ~TransportSequenceNumberAllocator() {}
410 390
411 virtual uint16_t AllocateSequenceNumber() = 0; 391 virtual uint16_t AllocateSequenceNumber() = 0;
412 }; 392 };
413 393
414 } // namespace webrtc 394 } // namespace webrtc
415 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_ 395 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/include/rtp_receiver.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698