Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: webrtc/p2p/base/faketransportcontroller.h

Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/faketransportcontroller.h
diff --git a/webrtc/p2p/base/faketransportcontroller.h b/webrtc/p2p/base/faketransportcontroller.h
index d5fbec4e39c59abed0353618882584364a2e1b2e..ea6e18c954b4f10c6359827e2a038d24db123a97 100644
--- a/webrtc/p2p/base/faketransportcontroller.h
+++ b/webrtc/p2p/base/faketransportcontroller.h
@@ -259,12 +259,11 @@ class FakeTransportChannel : public TransportChannelImpl,
return local_cert_;
}
- bool GetRemoteSSLCertificate(rtc::SSLCertificate** cert) const override {
- if (!remote_cert_)
- return false;
-
- *cert = remote_cert_->GetReference();
- return true;
+ rtc::scoped_ptr<rtc::SSLCertificate> GetRemoteSSLCertificate()
+ const override {
+ return remote_cert_ ? rtc::scoped_ptr<rtc::SSLCertificate>(
+ remote_cert_->GetReference())
+ : nullptr;
}
bool ExportKeyingMaterial(const std::string& label,

Powered by Google App Engine
This is Rietveld 408576698