webrtc/p2p/base/dtlstransportchannel.cc - Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/dtlstransportchannel.cc

Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/base/sslstreamadapter_unittest.cc ('K') | « webrtc/p2p/base/dtlstransportchannel.h ('k') | webrtc/p2p/base/dtlstransportchannel_unittest.cc » ('j') | webrtc/p2p/base/dtlstransportchannel_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/p2p/base/dtlstransportchannel.cc

diff --git a/webrtc/p2p/base/dtlstransportchannel.cc b/webrtc/p2p/base/dtlstransportchannel.cc

index 33b5b6f268e6cbc298f170b8504ca422116939d2..027f92be8ea21f78f16d718571102ad78f8ab75c 100644

--- a/webrtc/p2p/base/dtlstransportchannel.cc

+++ b/webrtc/p2p/base/dtlstransportchannel.cc

@@ -248,13 +248,13 @@ bool DtlsTransportChannelWrapper::SetRemoteFingerprint(

return true;

}

-bool DtlsTransportChannelWrapper::GetRemoteSSLCertificate(

- rtc::SSLCertificate** cert) const {

+rtc::scoped_ptr<rtc::SSLCertificate>

+DtlsTransportChannelWrapper::GetRemoteSSLCertificate() const {

if (!dtls_) {

- return false;

+ return nullptr;

}

- return dtls_->GetPeerCertificate(cert);

+ return dtls_->GetPeerCertificate();

}

bool DtlsTransportChannelWrapper::SetupDtls() {