Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Unified Diff: webrtc/base/opensslstreamadapter.cc

Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/opensslstreamadapter.cc
diff --git a/webrtc/base/opensslstreamadapter.cc b/webrtc/base/opensslstreamadapter.cc
index 052e54df9f33c840cf5ddf1e5f4e6e29eaf68c82..b8d1ad56e0c8939bb5c57a1fb3112dc57ec2d5df 100644
--- a/webrtc/base/opensslstreamadapter.cc
+++ b/webrtc/base/opensslstreamadapter.cc
@@ -294,12 +294,11 @@ void OpenSSLStreamAdapter::SetServerRole(SSLRole role) {
role_ = role;
}
-bool OpenSSLStreamAdapter::GetPeerCertificate(SSLCertificate** cert) const {
- if (!peer_certificate_)
- return false;
-
- *cert = peer_certificate_->GetReference();
- return true;
+rtc::scoped_ptr<SSLCertificate> OpenSSLStreamAdapter::GetPeerCertificate()
+ const {
+ return peer_certificate_ ? rtc::scoped_ptr<SSLCertificate>(
+ peer_certificate_->GetReference())
+ : nullptr;
}
bool OpenSSLStreamAdapter::SetPeerCertificateDigest(const std::string

Powered by Google App Engine
This is Rietveld 408576698